2024-03-05 11:33:47

by Rafael J. Wysocki

[permalink] [raw]
Subject: [PATCH v1] thermal: intel: int340x_thermal: Use thermal zone accessor functions

From: Rafael J. Wysocki <[email protected]>

Make int340x_thermal use the dedicated accessor functions for the
thermal zone device object address and the thermal zone type string.

This is requisite for future thermal core improvements.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-pm/drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
===================================================================
--- linux-pm.orig/drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
+++ linux-pm/drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
@@ -58,7 +58,8 @@ static int int340x_thermal_set_trip_temp

static void int340x_thermal_critical(struct thermal_zone_device *zone)
{
- dev_dbg(&zone->device, "%s: critical temperature reached\n", zone->type);
+ dev_dbg(thermal_zone_device(zone), "%s: critical temperature reached\n",
+ thermal_zone_device_type(zone));
}

static inline void *int_to_trip_priv(int i)





2024-03-05 16:09:14

by srinivas pandruvada

[permalink] [raw]
Subject: Re: [PATCH v1] thermal: intel: int340x_thermal: Use thermal zone accessor functions

On Tue, 2024-03-05 at 12:32 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> Make int340x_thermal use the dedicated accessor functions for the
> thermal zone device object address and the thermal zone type string.
>
> This is requisite for future thermal core improvements.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
Reviewed-by: Srinivas Pandruvada <[email protected]>

> ---
>  drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c |    3
> ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-
> pm/drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
> ===================================================================
> --- linux-
> pm.orig/drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
> +++ linux-
> pm/drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
> @@ -58,7 +58,8 @@ static int int340x_thermal_set_trip_temp
>  
>  static void int340x_thermal_critical(struct thermal_zone_device
> *zone)
>  {
> -       dev_dbg(&zone->device, "%s: critical temperature reached\n",
> zone->type);
> +       dev_dbg(thermal_zone_device(zone), "%s: critical temperature
> reached\n",
> +               thermal_zone_device_type(zone));
>  }
>  
>  static inline void *int_to_trip_priv(int i)
>
>
>