From: Minghao Chi <[email protected]>
Return status directly from function called.
Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
net/batman-adv/network-coding.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 0a7f1d36a6a8..0c300476d335 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -58,13 +58,9 @@ static int batadv_nc_recv_coded_packet(struct sk_buff *skb,
*/
int __init batadv_nc_init(void)
{
- int ret;
-
/* Register our packet type */
- ret = batadv_recv_handler_register(BATADV_CODED,
+ return batadv_recv_handler_register(BATADV_CODED,
batadv_nc_recv_coded_packet);
-
- return ret;
}
/**
--
2.25.1
On Friday, 10 December 2021 03:19:17 CET [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Return status directly from function called.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
Applied after fixing obvious coding style problems.
Please try to fix the script which creates these automated patch submissions.
Kind regards,
Sven
On Friday, 10 December 2021 03:19:17 CET [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Return status directly from function called.
>
> Reported-by: Zeal Robot <[email protected]>
And the Reported-by (robot) using a mail address which is bouncing.
<[email protected]>: Host or domain name not found. Name service error for
name=zte.com.cm type=AAAA: Host not found
Please fix this too in your scripts.
Kind regards,
Sven
From: Minghao Chi <[email protected]>
Return status directly from function called.
change since v1: [email protected]
v2: [email protected]
Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
net/batman-adv/network-coding.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 0a7f1d36a6a8..0c300476d335 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -58,13 +58,9 @@ static int batadv_nc_recv_coded_packet(struct sk_buff *skb,
*/
int __init batadv_nc_init(void)
{
- int ret;
-
/* Register our packet type */
- ret = batadv_recv_handler_register(BATADV_CODED,
+ return batadv_recv_handler_register(BATADV_CODED,
batadv_nc_recv_coded_packet);
-
- return ret;
}
/**
--
2.25.1
On Friday, 10 December 2021 10:42:06 CET [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Return status directly from function called.
> change since v1: [email protected]
> v2: [email protected]
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
This is wrong:
1. the patch was already applied
2. the patch history doesn't belong in the commit message
3. there is still an alignment problem
4. if you use -v in git-format-patch then it should be "PATCH v2" and not
"PATCHv2" (otherwise it will not be parsed correctly by patchwork)
5. The alignment problem is still there
6. the subject is also not following the normal formatting style
Kind regards,
Sven