On 11/08/2017 12:55 AM, lei yang wrote:
>
>
> On 2017年11月08日 06:57, Shuah Khan wrote:
>> On 11/06/2017 06:18 PM, lei yang wrote:
>>>
>>> On 2017年11月07日 07:48, Shuah Khan wrote:
>>>> On 11/06/2017 04:45 PM, Shuah Khan wrote:
>>>>> On 11/05/2017 09:03 PM, Lei Yang wrote:
>>>>>> I run into below error when building futext
>>>>>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>>>>>
>>>>>> the closing ";" and "\" are necessary.
>>>>>> My OS is "Ubuntu 14.04.5 LTS"
>>>>>>
>>>>>> Signed-off-by: Lei Yang <[email protected]>
>>>>>> ---
>>>>>> tools/testing/selftests/futex/Makefile | 6 +++---
>>>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>>>
>>>>>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>>>>>> index f0c0369..943f3a2 100644
>>>>>> --- a/tools/testing/selftests/futex/Makefile
>>>>>> +++ b/tools/testing/selftests/futex/Makefile
>>>>>> @@ -11,9 +11,9 @@ all:
>>>>>> BUILD_TARGET=$(OUTPUT)/$$DIR; \
>>>>>> mkdir $$BUILD_TARGET -p; \
>>>>>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>>>>>> - if [ -e $$DIR/$(TEST_PROGS) ]; then
>>>>>> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>>>>>> - fi
>>>>>> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
>>>>>> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>>>>>> + fi \
>>>>>> done
>>>>>> override define RUN_TESTS
>>>>>>
>>>>> Hmm. I don't see this error on linux_4.14-rc8?
>>>>>
>>>>> Can you give more details on the gcc version you are using?
>>>> I meant gnumake version? I am not seeing the failure with what I am
>>>> using
>>> $ make -v
>>> GNU Make 3.81
>>> Copyright (C) 2006 Free Software Foundation, Inc.
>>> This is free software; see the source for copying conditions.
>>> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
>>> PARTICULAR PURPOSE.
>>>
>>> This program built for x86_64-pc-linux-gnu
>>>
>>>
>>> Lei
>>>
>> I can't take patches that aren't tested on the latest kernel release.
>> 3.16 is very old. I am not going reply to other patches you sent.
>>
>> Please make sure the patches are based on the latest release and tested
>> on it as well.
>
> this error only happens when use old version "make", it has nothing to do with the new or old kernel.
>
> so the question is do we need to be compatible with old "make" ?
>
> Lei
>
Like I said, Linux 3.16 kernel is very old and I won't take patches that
are tested on it.
thanks,
-- Shuah
From 1583483747059664312@xxx Wed Nov 08 07:56:20 +0000 2017
X-GM-THRID: 1583288022901438905
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread