2022-11-23 13:49:27

by Sasha Levin

[permalink] [raw]
Subject: [PATCH AUTOSEL 5.15 23/31] block: make blk_set_default_limits() private

From: Keith Busch <[email protected]>

[ Upstream commit b3228254bb6e91e57f920227f72a1a7d81925d81 ]

There are no external users of this function.

Signed-off-by: Keith Busch <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
block/blk-settings.c | 1 -
block/blk.h | 1 +
include/linux/blkdev.h | 1 -
3 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index b880c70e22e4..aaedcbc20003 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -58,7 +58,6 @@ void blk_set_default_limits(struct queue_limits *lim)
lim->zoned = BLK_ZONED_NONE;
lim->zone_write_granularity = 0;
}
-EXPORT_SYMBOL(blk_set_default_limits);

/**
* blk_set_stacking_limits - set default limits for stacking devices
diff --git a/block/blk.h b/block/blk.h
index aab72194d226..8af560ec6b39 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -236,6 +236,7 @@ void blk_rq_set_mixed_merge(struct request *rq);
bool blk_rq_merge_ok(struct request *rq, struct bio *bio);
enum elv_merge blk_try_merge(struct request *rq, struct bio *bio);

+void blk_set_default_limits(struct queue_limits *lim);
int blk_dev_init(void);

/*
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 67344dfe07a7..fa923f4e0344 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1126,7 +1126,6 @@ extern void blk_queue_io_min(struct request_queue *q, unsigned int min);
extern void blk_limits_io_opt(struct queue_limits *limits, unsigned int opt);
extern void blk_queue_io_opt(struct request_queue *q, unsigned int opt);
extern void blk_set_queue_depth(struct request_queue *q, unsigned int depth);
-extern void blk_set_default_limits(struct queue_limits *lim);
extern void blk_set_stacking_limits(struct queue_limits *lim);
extern int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
sector_t offset);
--
2.35.1


2022-11-23 14:47:20

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH AUTOSEL 5.15 23/31] block: make blk_set_default_limits() private

On 11/23/22 5:42 AM, Sasha Levin wrote:
> From: Keith Busch <[email protected]>
>
> [ Upstream commit b3228254bb6e91e57f920227f72a1a7d81925d81 ]
>
> There are no external users of this function.

Please drop the 5.15 and earlier backports of this series, it's
not needed.

--
Jens Axboe


2022-11-30 11:31:41

by Sasha Levin

[permalink] [raw]
Subject: Re: [PATCH AUTOSEL 5.15 23/31] block: make blk_set_default_limits() private

On Wed, Nov 23, 2022 at 06:44:02AM -0700, Jens Axboe wrote:
>On 11/23/22 5:42 AM, Sasha Levin wrote:
>> From: Keith Busch <[email protected]>
>>
>> [ Upstream commit b3228254bb6e91e57f920227f72a1a7d81925d81 ]
>>
>> There are no external users of this function.
>
>Please drop the 5.15 and earlier backports of this series, it's
>not needed.

Will do, thanks!

--
Thanks,
Sasha