2011-04-12 07:36:04

by J. R. Okajima

[permalink] [raw]
Subject: O_EXCL in NFSv3


Hello Trond,

The commit in v2.6.37
c0204fd 2010-09-17 NFS: Clean up nfs4_proc_create()
looks totally dropping O_EXCL flag from NFSv3.
But fs/nfs/nfs3proc.c:nfs3_proc_create() and
fs/nfsd/nfs3proc.c:nfsd3_proc_create() still expect O_EXCL to be passed.

And the commit log says "Clean up nfs4_proc_create()".
Is this change for NFSv3 intentional?
Actually O_EXCL in NFSv3 doesn't work in v2.6.37 and later.


J. R. Okajima


2011-04-12 11:56:18

by Myklebust, Trond

[permalink] [raw]
Subject: Re: O_EXCL in NFSv3

On Tue, 2011-04-12 at 16:35 +0900, J. R. Okajima wrote:
> Hello Trond,
>
> The commit in v2.6.37
> c0204fd 2010-09-17 NFS: Clean up nfs4_proc_create()
> looks totally dropping O_EXCL flag from NFSv3.
> But fs/nfs/nfs3proc.c:nfs3_proc_create() and
> fs/nfsd/nfs3proc.c:nfsd3_proc_create() still expect O_EXCL to be passed.
>
> And the commit log says "Clean up nfs4_proc_create()".
> Is this change for NFSv3 intentional?
> Actually O_EXCL in NFSv3 doesn't work in v2.6.37 and later.

Doesn't commit 8a0eebf66e3b1deae036553ba641a9c2bdbae678 (NFS: Fix NFSv3
exclusive open semantics) fix this? It should be in the stable tree.

--
Trond Myklebust
Linux NFS client maintainer

NetApp
[email protected]
http://www.netapp.com

2011-04-12 12:15:35

by J. R. Okajima

[permalink] [raw]
Subject: Re: O_EXCL in NFSv3


Trond Myklebust:
> Doesn't commit 8a0eebf66e3b1deae036553ba641a9c2bdbae678 (NFS: Fix NFSv3
> exclusive open semantics) fix this? It should be in the stable tree.

Ah, I can see the commit in v2.6.38.
So it is fixed already, sorry.
I just skipped all NFS tests for v2.6.38. due to the sillyrename
problem.
Also I know it was fixed just after v2.6.38(.0).

Thank you
J. R. Okajima