2020-04-21 12:00:27

by Jianpeng Ma

[permalink] [raw]
Subject: [RESEND]block: remove unused header

Dax related code already removed from this file.

Signed-off-by: Jianpeng Ma <[email protected]>
---
fs/block_dev.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 52b6f646cdbd..4163435dc231 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -19,7 +19,6 @@
#include <linux/module.h>
#include <linux/blkpg.h>
#include <linux/magic.h>
-#include <linux/dax.h>
#include <linux/buffer_head.h>
#include <linux/swap.h>
#include <linux/pagevec.h>
--
2.17.1

> -----Original Message-----
> From: Christoph Hellwig <[email protected]>
> Sent: Tuesday, April 21, 2020 7:33 PM
> To: Ma, Jianpeng <[email protected]>
> Cc: [email protected]; Williams, Dan J <[email protected]>; linux-
> [email protected]
> Subject: Re: block: remove unused header
>
> On Tue, Apr 21, 2020 at 05:48:46AM +0000, Ma, Jianpeng wrote:
> > >From 95218bc1d79f2bcbdd8819be26efa698868a34ca Mon Sep 17 00:00:00
> 2001
> > From: Jianpeng Ma <[email protected]>
> > Date: Tue, 21 Apr 2020 01:15:24 -0400
> > Subject: [PATCH] block: remove unused header.
> >
> > Dax related code already removed from this file.
> >
> > Signed-off-by: Jianpeng Ma <[email protected]>
>
> Except for the mangled patch format this looks good:
>
> Reviewed-by: Christoph Hellwig <[email protected]>
>
> Can you resend it with proper patch headers?


2020-04-21 12:22:22

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [RESEND]block: remove unused header

On Tue, Apr 21, 2020 at 11:48:08AM +0000, Ma, Jianpeng wrote:
> Dax related code already removed from this file.
>
> Signed-off-by: Jianpeng Ma <[email protected]>

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2020-04-21 15:53:27

by Jens Axboe

[permalink] [raw]
Subject: Re: [RESEND]block: remove unused header

On 4/21/20 5:48 AM, Ma, Jianpeng wrote:
> Dax related code already removed from this file.

Applied, thanks.

--
Jens Axboe