2018-01-21 21:15:13

by SF Markus Elfring

Subject: [PATCH 0/2] Input: auo-pixcir-ts: Adjustments for two function implementations

From: Markus Elfring <[email protected]>
Date: Sun, 21 Jan 2018 22:10:44 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
in auo_pixcir_parse_dt()
Delete an unnecessary return statement in auo_pixcir_input_close()

drivers/input/touchscreen/auo-pixcir-ts.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

--
2.16.0

2018-01-21 21:16:54

by SF Markus Elfring

Subject: [PATCH 1/2] Input: auo-pixcir-ts: Delete an error message for a failed memory allocation in auo_pixcir_parse_dt()

From: Markus Elfring <[email protected]>
Date: Sun, 21 Jan 2018 22:02:32 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/auo-pixcir-ts.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/auo-pixcir-ts.c b/drivers/input/touchscreen/auo-pixcir-ts.c
index 6592fc5d48b4..398e27c48a51 100644
--- a/drivers/input/touchscreen/auo-pixcir-ts.c
+++ b/drivers/input/touchscreen/auo-pixcir-ts.c
@@ -487,10 +487,8 @@ static struct auo_pixcir_ts_platdata *auo_pixcir_parse_dt(struct device *dev)
return ERR_PTR(-ENOENT);

pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
- if (!pdata) {
- dev_err(dev, "failed to allocate platform data\n");
+ if (!pdata)
return ERR_PTR(-ENOMEM);
- }

pdata->gpio_int = of_get_gpio(np, 0);
if (!gpio_is_valid(pdata->gpio_int)) {
--
2.16.0

2018-01-21 21:17:33

by SF Markus Elfring

Subject: [PATCH 2/2] Input: auo-pixcir-ts: Delete an unnecessary return statement in auo_pixcir_input_close()

From: Markus Elfring <[email protected]>
Date: Sun, 21 Jan 2018 22:06:28 +0100

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/auo-pixcir-ts.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/input/touchscreen/auo-pixcir-ts.c b/drivers/input/touchscreen/auo-pixcir-ts.c
index 398e27c48a51..df8ca856393b 100644
--- a/drivers/input/touchscreen/auo-pixcir-ts.c
+++ b/drivers/input/touchscreen/auo-pixcir-ts.c
@@ -408,8 +408,6 @@ static void auo_pixcir_input_close(struct input_dev *dev)
struct auo_pixcir_ts *ts = input_get_drvdata(dev);

auo_pixcir_stop(ts);
-
- return;
}

static int __maybe_unused auo_pixcir_suspend(struct device *dev)
--
2.16.0

2018-01-21 21:36:21

by Heiko Stuebner

Subject: Re: [PATCH 0/2] Input: auo-pixcir-ts: Adjustments for two function implementations

Am Sonntag, 21. Januar 2018, 22:14:15 CET schrieb SF Markus Elfring:
> From: Markus Elfring <[email protected]>
> Date: Sun, 21 Jan 2018 22:10:44 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Delete an error message for a failed memory allocation
> in auo_pixcir_parse_dt()
> Delete an unnecessary return statement in auo_pixcir_input_close()

if it helps, both
Reviewed-by: Heiko Stuebner <[email protected]>