2023-12-07 08:04:26

by Andy Yan

[permalink] [raw]
Subject: [PATCH v4 15/17] dt-bindings: iommu: rockchip: Add Rockchip RK3588

From: Andy Yan <[email protected]>

Add a Rockchip RK3588 compatible

Signed-off-by: Andy Yan <[email protected]>

---

Changes in v4:
- Add const for rockchip,rk3588-iommu compatible

.../devicetree/bindings/iommu/rockchip,iommu.yaml | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
index ba9124f721f1..621dde0e45d8 100644
--- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
@@ -19,9 +19,14 @@ description: |+

properties:
compatible:
- enum:
- - rockchip,iommu
- - rockchip,rk3568-iommu
+ oneOf:
+ - enum:
+ - rockchip,iommu
+ - rockchip,rk3568-iommu
+ - items:
+ - enum:
+ - rockchip,rk3588-iommu
+ - const: rockchip,rk3568-iommu

reg:
items:
--
2.34.1


2023-12-08 16:29:27

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH v4 15/17] dt-bindings: iommu: rockchip: Add Rockchip RK3588

Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan:
> From: Andy Yan <[email protected]>
>
> Add a Rockchip RK3588 compatible
>
> Signed-off-by: Andy Yan <[email protected]>

Reviewed-by: Heiko Stuebner <[email protected]>

In the next iteration, please split this out into a separate patch and send
it to the iommu+dt maintainers.

Supporting the iommus on rk3588 can be realized separately and the
patch needs to go through a separate tree anyway.


Thanks
Heiko



2023-12-08 17:47:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 15/17] dt-bindings: iommu: rockchip: Add Rockchip RK3588

On 07/12/2023 09:02, Andy Yan wrote:
> From: Andy Yan <[email protected]>
>
> Add a Rockchip RK3588 compatible
>
> Signed-off-by: Andy Yan <[email protected]>

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-12-09 01:36:29

by Andy Yan

[permalink] [raw]
Subject: Re: [PATCH v4 15/17] dt-bindings: iommu: rockchip: Add Rockchip RK3588

Hi Heiko:

On 12/9/23 00:29, Heiko Stübner wrote:
> Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan:
>> From: Andy Yan <[email protected]>
>>
>> Add a Rockchip RK3588 compatible
>>
>> Signed-off-by: Andy Yan <[email protected]>
>
> Reviewed-by: Heiko Stuebner <[email protected]>
>
> In the next iteration, please split this out into a separate patch and send
> it to the iommu+dt maintainers.
>
> Supporting the iommus on rk3588 can be realized separately and the
> patch needs to go through a separate tree anyway.

Okay, I will split this patch out of this vop2 series, does this mean that
I also need to split out the iommu dt node as a separate patch from current
PATCH16 ?
>
>
> Thanks
> Heiko
>
>
>

2023-12-09 14:05:17

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH v4 15/17] dt-bindings: iommu: rockchip: Add Rockchip RK3588

Hi Andy,

Am Samstag, 9. Dezember 2023, 02:26:25 CET schrieb Andy Yan:
> Hi Heiko:
>
> On 12/9/23 00:29, Heiko St?bner wrote:
> > Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan:
> >> From: Andy Yan <[email protected]>
> >>
> >> Add a Rockchip RK3588 compatible
> >>
> >> Signed-off-by: Andy Yan <[email protected]>
> >
> > Reviewed-by: Heiko Stuebner <[email protected]>
> >
> > In the next iteration, please split this out into a separate patch and send
> > it to the iommu+dt maintainers.
> >
> > Supporting the iommus on rk3588 can be realized separately and the
> > patch needs to go through a separate tree anyway.
>
> Okay, I will split this patch out of this vop2 series, does this mean that
> I also need to split out the iommu dt node as a separate patch from current
> PATCH16 ?

no :-) .

The vop-iommu can stay together with the vop core node.
As adding the actual vop iommu is very much tied to the vop node.

For the iommu-compatible it was different. The compatible just declares
that the iommu acts similar to the one on rk3568, so is related to the iommu
driver itself and should go through the iommu tree.

So all is good here.

Heiko