2022-04-15 15:31:19

by Andy Shevchenko

Subject: [PATCH v1 1/1] iio: trigger: stm32-lptimer-trigger: Make use of device properties

Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/iio/trigger/stm32-lptimer-trigger.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/trigger/stm32-lptimer-trigger.c b/drivers/iio/trigger/stm32-lptimer-trigger.c
index 98cdc7e47f3d..af46c10cea92 100644
--- a/drivers/iio/trigger/stm32-lptimer-trigger.c
+++ b/drivers/iio/trigger/stm32-lptimer-trigger.c
@@ -13,6 +13,7 @@
#include <linux/mfd/stm32-lptimer.h>
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/property.h>

/* List Low-Power Timer triggers */
static const char * const stm32_lptim_triggers[] = {
@@ -77,7 +78,7 @@ static int stm32_lptim_trigger_probe(struct platform_device *pdev)
if (!priv)
return -ENOMEM;

- if (of_property_read_u32(pdev->dev.of_node, "reg", &index))
+ if (device_property_read_u32(&pdev->dev, "reg", &index))
return -EINVAL;

if (index >= ARRAY_SIZE(stm32_lptim_triggers))
--
2.35.1

2022-04-29 09:23:32

by Jonathan Cameron

Subject: Re: [PATCH v1 1/1] iio: trigger: stm32-lptimer-trigger: Make use of device properties

On Wed, 13 Apr 2022 21:56:56 +0300
Andy Shevchenko <[email protected]> wrote:

> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

MAINTAINERS entry for this one uses extensive wild cards so may
escape scripts...

+CC Fabrice.

> ---
> drivers/iio/trigger/stm32-lptimer-trigger.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/trigger/stm32-lptimer-trigger.c b/drivers/iio/trigger/stm32-lptimer-trigger.c
> index 98cdc7e47f3d..af46c10cea92 100644
> --- a/drivers/iio/trigger/stm32-lptimer-trigger.c
> +++ b/drivers/iio/trigger/stm32-lptimer-trigger.c
> @@ -13,6 +13,7 @@
> #include <linux/mfd/stm32-lptimer.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> +#include <linux/property.h>
>
> /* List Low-Power Timer triggers */
> static const char * const stm32_lptim_triggers[] = {
> @@ -77,7 +78,7 @@ static int stm32_lptim_trigger_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - if (of_property_read_u32(pdev->dev.of_node, "reg", &index))
> + if (device_property_read_u32(&pdev->dev, "reg", &index))
> return -EINVAL;
>
> if (index >= ARRAY_SIZE(stm32_lptim_triggers))

2022-05-03 13:32:09

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] iio: trigger: stm32-lptimer-trigger: Make use of device properties

On Thu, Apr 28, 2022 at 07:33:04PM +0100, Jonathan Cameron wrote:
> On Wed, 13 Apr 2022 21:56:56 +0300
> Andy Shevchenko <[email protected]> wrote:
>
> > Convert the module to be property provider agnostic and allow
> > it to be used on non-OF platforms.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> MAINTAINERS entry for this one uses extensive wild cards so may
> escape scripts...
>
> +CC Fabrice.

Thanks!

Not sure it might break anything, it's quite straightforward conversion.

--
With Best Regards,
Andy Shevchenko

2022-05-04 15:50:32

by Fabrice Gasnier

Subject: Re: [PATCH v1 1/1] iio: trigger: stm32-lptimer-trigger: Make use of device properties

On 5/3/22 12:20, Andy Shevchenko wrote:
> On Thu, Apr 28, 2022 at 07:33:04PM +0100, Jonathan Cameron wrote:
>> On Wed, 13 Apr 2022 21:56:56 +0300
>> Andy Shevchenko <[email protected]> wrote:
>>
>>> Convert the module to be property provider agnostic and allow
>>> it to be used on non-OF platforms.
>>>
>>> Signed-off-by: Andy Shevchenko <[email protected]>
>>
>> MAINTAINERS entry for this one uses extensive wild cards so may
>> escape scripts...
>>
>> +CC Fabrice.
>
> Thanks!
>
> Not sure it might break anything, it's quite straightforward conversion.

Hi Andy, Jonathan,

You can add my:
Reviewed-by: Fabrice Gasnier <[email protected]>

Thanks,
Best Regards,
Fabrice

>

2022-05-09 03:29:17

by Jonathan Cameron

Subject: Re: [PATCH v1 1/1] iio: trigger: stm32-lptimer-trigger: Make use of device properties

On Tue, 3 May 2022 14:25:37 +0200
Fabrice Gasnier <[email protected]> wrote:

> On 5/3/22 12:20, Andy Shevchenko wrote:
> > On Thu, Apr 28, 2022 at 07:33:04PM +0100, Jonathan Cameron wrote:
> >> On Wed, 13 Apr 2022 21:56:56 +0300
> >> Andy Shevchenko <[email protected]> wrote:
> >>
> >>> Convert the module to be property provider agnostic and allow
> >>> it to be used on non-OF platforms.
> >>>
> >>> Signed-off-by: Andy Shevchenko <[email protected]>
> >>
> >> MAINTAINERS entry for this one uses extensive wild cards so may
> >> escape scripts...
> >>
> >> +CC Fabrice.
> >
> > Thanks!
> >
> > Not sure it might break anything, it's quite straightforward conversion.
>
> Hi Andy, Jonathan,
>
> You can add my:
> Reviewed-by: Fabrice Gasnier <[email protected]>

Applied to the togreg branch of iio.git and pushed out as testing to
let 0-day see if it can find anything we missed.

Thanks,

Jonathan


>
> Thanks,
> Best Regards,
> Fabrice
>
> >