Hi,
On 2023-09-27 18:22, Sven Frotscher wrote:
>
> Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8)
> requires an entry in the quirk list to enable the internal microphone.
> The latter two received similar fixes in commit 1263cc0f, see
> https://lore.kernel.org/r/[email protected].
>
> Signed-off-by: Sven Frotscher <[email protected]>
Since this fixes a regression caused by commit c008323fe361 which has
been backported to stable, please add "Fixes:" and "Cc:" tags above the
"Signed-off-by:" tag to ensure the fix also gets backported in a timely
manner [1]:
Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo 82SJ")
Cc: [email protected]
> ---
> sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 3d8a51351e29..e3d2b9d01552 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -241,6 +241,13 @@ static const struct dmi_system_id
> yc_acp_quirk_table[] = {
> >..>...>...DMI_MATCH(DMI_PRODUCT_NAME, "82V2"),
> >..>...}
> >..},
> +>..{
> +>..>....driver_data = &acp6x_card,
> +>..>....matches = {
> +>..>...>...DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +>..>...>...DMI_MATCH(DMI_PRODUCT_NAME, "82YM"),
> +>..>...}
> +>..},
> >..{
> >..>....driver_data = &acp6x_card,
> >..>....matches = {
Your e-mail client seems to have mangled the leading whitespace here,
which will prevent the patch from applying cleanly. It is strongly
recommended [2] to use git send-email for sending patches, see [3] for a
tutorial on how to set up and use it. For other e-mail clients, see [4].
[1] https://www.kernel.org/doc/html/latest/process/handling-regressions.html#what-s-important-when-fixing-regressions
[2] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
[3] https://git-send-email.io/
[4] https://www.kernel.org/doc/html/latest/process/email-clients.html
Regards,
August Wikerfors
Hello,
> > Signed-off-by: Sven Frotscher <[email protected]>
> Since this fixes a regression caused by commit c008323fe361 which has
> been backported to stable, please add "Fixes:" and "Cc:" tags above
the
> "Signed-off-by:" tag to ensure the fix also gets backported in a
timely
> manner [1]:
>
> Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on
Lenovo 82SJ")
> Cc: [email protected]
I will.
> > +>..>...>...DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> > +>..>...>...DMI_MATCH(DMI_PRODUCT_NAME, "82YM"),
> Your e-mail client seems to have mangled the leading whitespace here,
> which will prevent the patch from applying cleanly.
My e-mail client isn't the problem here, but my Vim syntax highlighting
for tabs... I should've noticed that when copy-pasting from test e-mail
to patch e-mail via Vim.
Should I reply to this thread with a [PATCH v2] message or create a new
thread?
Anyway, thank you for pointing out these issues.
Regards,
Sven
On 2023-09-27 20:49, Sven Frotscher wrote:
> Hello,
>
> > > Signed-off-by: Sven Frotscher <[email protected]>
> > Since this fixes a regression caused by commit c008323fe361 which has
> > been backported to stable, please add "Fixes:" and "Cc:" tags above the
> > "Signed-off-by:" tag to ensure the fix also gets backported in a timely
> > manner [1]:
> >
> > Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on
> Lenovo 82SJ")
> > Cc: [email protected]
> I will.
>
> > > +>..>...>...DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> > > +>..>...>...DMI_MATCH(DMI_PRODUCT_NAME, "82YM"),
> > Your e-mail client seems to have mangled the leading whitespace here,
> > which will prevent the patch from applying cleanly.
> My e-mail client isn't the problem here, but my Vim syntax highlighting
> for tabs... I should've noticed that when copy-pasting from test e-mail
> to patch e-mail via Vim.
>
> Should I reply to this thread with a [PATCH v2] message or create a new
> thread?
AFAIK either way is fine, separate thread seems more common though.