2022-11-28 05:44:48

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warnings after merge of the v4l-dvb-next tree

---

Hi all,

After merging the v4l-dvb-next tree, today's linux-next build (htmldocs)
produced these warnings:

include/media/dvbdev.h:193: warning: Function parameter or member 'ref' not described in 'dvb_device'
include/media/dvbdev.h:207: warning: expecting prototype for dvb_device_get(). Prototype was for dvb_device_put() instead

Introduced by commit

0fc044b2b5e2 ("media: dvbdev: adopts refcnt to avoid UAF")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-11-28 08:20:56

by Lin Ma

[permalink] [raw]

Subject: Re: linux-next: build warnings after merge of the v4l-dvb-next tree

---

Hi Stephen,

> Hi all,
>
> After merging the v4l-dvb-next tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> include/media/dvbdev.h:193: warning: Function parameter or member 'ref' not described in 'dvb_device'
> include/media/dvbdev.h:207: warning: expecting prototype for dvb_device_get(). Prototype was for dvb_device_put() instead
>
> Introduced by commit
>
> 0fc044b2b5e2 ("media: dvbdev: adopts refcnt to avoid UAF")
>
> --

Oh my bad, it seems that I leave a typo there as forgetting about the function name in comment.

/**
* dvb_device_get - Decrease dvb_device reference
*
* @dvbdev: pointer to struct dvb_device
*/
void dvb_device_put(struct dvb_device *dvbdev);

Also the 'ref' field is not described with comment. Will send the fix to the v4l-dvb-next soon.

Thanks
Lin