2014-10-08 19:49:47

by Peter Foley

Subject: [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit

vdso_standalone_test_x86 needs -lgcc_s to build succesfully on 32bit.

Signed-off-by: Peter Foley <[email protected]>
---
Documentation/vDSO/Makefile | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
index 2b99e57..5e5ad9f 100644
--- a/Documentation/vDSO/Makefile
+++ b/Documentation/vDSO/Makefile
@@ -10,3 +10,6 @@ always := $(hostprogs-y)
HOSTCFLAGS := -I$(objtree)/usr/include -std=gnu99
HOSTCFLAGS_vdso_standalone_test_x86.o := -fno-asynchronous-unwind-tables -fno-stack-protector
HOSTLOADLIBES_vdso_standalone_test_x86 := -nostdlib
+ifeq($(CONFIG_X86_32),y)
+HOSTLOADLIBES_vdso_standalone_test_x86 += -lgcc_s
+endif
--
2.1.2

2014-10-08 19:54:52

by H. Peter Anvin

Subject: Re: [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit

This still has the cross-build problems, no?

On October 8, 2014 12:49:24 PM PDT, Peter Foley <[email protected]> wrote:
>vdso_standalone_test_x86 needs -lgcc_s to build succesfully on 32bit.
>
>Signed-off-by: Peter Foley <[email protected]>
>---
> Documentation/vDSO/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
>index 2b99e57..5e5ad9f 100644
>--- a/Documentation/vDSO/Makefile
>+++ b/Documentation/vDSO/Makefile
>@@ -10,3 +10,6 @@ always := $(hostprogs-y)
> HOSTCFLAGS := -I$(objtree)/usr/include -std=gnu99
>HOSTCFLAGS_vdso_standalone_test_x86.o :=
>-fno-asynchronous-unwind-tables -fno-stack-protector
> HOSTLOADLIBES_vdso_standalone_test_x86 := -nostdlib
>+ifeq($(CONFIG_X86_32),y)
>+HOSTLOADLIBES_vdso_standalone_test_x86 += -lgcc_s
>+endif

--
Sent from my mobile phone. Please pardon brevity and lack of formatting.

2014-10-08 22:53:19

by Peter Foley

Subject: Re: [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit

On Wed, Oct 8, 2014 at 3:54 PM, H. Peter Anvin <[email protected]> wrote:
> This still has the cross-build problems, no?
>

Yes, but that issue is more general to CONFIG_BUILD_DOCSRC.
This is just a build failure on x86-32.

2014-10-20 12:23:34

by Paul Bolle

Subject: Re: [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit

Peter Foley schreef op wo 08-10-2014 om 15:49 [-0400]:
> vdso_standalone_test_x86 needs -lgcc_s to build succesfully on 32bit.
>
> Signed-off-by: Peter Foley <[email protected]>
> ---
> Documentation/vDSO/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
> index 2b99e57..5e5ad9f 100644
> --- a/Documentation/vDSO/Makefile
> +++ b/Documentation/vDSO/Makefile
> @@ -10,3 +10,6 @@ always := $(hostprogs-y)
> HOSTCFLAGS := -I$(objtree)/usr/include -std=gnu99
> HOSTCFLAGS_vdso_standalone_test_x86.o := -fno-asynchronous-unwind-tables -fno-stack-protector
> HOSTLOADLIBES_vdso_standalone_test_x86 := -nostdlib
> +ifeq($(CONFIG_X86_32),y)
> +HOSTLOADLIBES_vdso_standalone_test_x86 += -lgcc_s
> +endif

Applying this patch on top of v3.18-rc1 to get it to build for 32 bit
x86 triggers this build error (when calling "make -s mrproper", which is
done early in the build of a Fedora kernel rpm):
Documentation/vDSO/Makefile:13: *** missing separator. Stop.
make[1]: *** [Documentation/vDSO] Error 2
make: *** [_clean_Documentation] Error 2

Using
ifeq ($(CONFIG_X86_32),y)

fixes that error. And with that space added this patch unbreaks the
build of v3.18-rc1 for 32 bit x86.

Thanks,


Paul Bolle