2023-12-21 14:15:38

by Andy Shevchenko

Subject: [PATCH v1 1/1] pvpanic: Kill duplicate PCI_VENDOR_ID_REDHAT definition

PCI_VENDOR_ID_REDHAT is already defined in pci_ids.h. Kill the dup.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/misc/pvpanic/pvpanic-pci.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
index 689af4c28c2a..c5fb6298cb8d 100644
--- a/drivers/misc/pvpanic/pvpanic-pci.c
+++ b/drivers/misc/pvpanic/pvpanic-pci.c
@@ -15,7 +15,6 @@

#include "pvpanic.h"

-#define PCI_VENDOR_ID_REDHAT 0x1b36
#define PCI_DEVICE_ID_REDHAT_PVPANIC 0x0011

MODULE_AUTHOR("Mihai Carabas <[email protected]>");
--
2.43.0.rc1.1.gbec44491f096

2023-12-21 17:46:58

by Thomas Weißschuh

Subject: Re: [PATCH v1 1/1] pvpanic: Kill duplicate PCI_VENDOR_ID_REDHAT definition

Dec 21, 2023 15:15:32 Andy Shevchenko <[email protected]>:

> PCI_VENDOR_ID_REDHAT is already defined in pci_ids.h. Kill the dup.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Thomas Weißschuh <[email protected]>

> ---
> drivers/misc/pvpanic/pvpanic-pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
> index 689af4c28c2a..c5fb6298cb8d 100644
> --- a/drivers/misc/pvpanic/pvpanic-pci.c
> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
> @@ -15,7 +15,6 @@
>
> #include "pvpanic.h"
>
> -#define PCI_VENDOR_ID_REDHAT             0x1b36
> #define PCI_DEVICE_ID_REDHAT_PVPANIC     0x0011
>
> MODULE_AUTHOR("Mihai Carabas <[email protected]>");
> --
> 2.43.0.rc1.1.gbec44491f096