2022-11-27 17:36:35

by <Vishal Badole>

[permalink] [raw]
Subject: [PATCH v5] Common clock: To list active consumers of clocks

This feature lists the clock consumer's name and respective connection
id. Using this feature user can easily check that which user has
acquired and enabled a particular clock.

Usage:
>> cat /sys/kernel/debug/clk/clk_summary
enable prepare protect
duty hardware Connection
clock count count count rate accuracy phase cycle enable consumer Id
------------------------------------------------------------------------------------------------------------------------------
clk_mcasp0_fixed 0 0 0 24576000 0 0 50000 Y deviceless of_clk_get_from_provider
deviceless no_connection_id
clk_mcasp0 0 0 0 24576000 0 0 50000 N simple-audio-card,cpu no_connection_id
deviceless no_connection_id

Co-developed-by: Chinmoy Ghosh <[email protected]>
Signed-off-by: Chinmoy Ghosh <[email protected]>
Co-developed-by: Mintu Patel <[email protected]>
Signed-off-by: Mintu Patel <[email protected]>
Co-developed-by: Vimal Kumar <[email protected]>
Signed-off-by: Vimal Kumar <[email protected]>
Signed-off-by: Vishal Badole <[email protected]>
---
drivers/clk/clk.c | 34 ++++++++++++++++++++++++----------
1 file changed, 24 insertions(+), 10 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index bd0b35c..c4aa3b4 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2952,28 +2952,41 @@ static void clk_summary_show_one(struct seq_file *s, struct clk_core *c,
int level)
{
int phase;
+ struct clk *clk_user;
+ int multi_node = 0;

- seq_printf(s, "%*s%-*s %7d %8d %8d %11lu %10lu ",
+ seq_printf(s, "%*s%-*s %-7d %-8d %-8d %-11lu %-10lu ",
level * 3 + 1, "",
- 30 - level * 3, c->name,
+ 35 - level * 3, c->name,
c->enable_count, c->prepare_count, c->protect_count,
clk_core_get_rate_recalc(c),
clk_core_get_accuracy_recalc(c));

phase = clk_core_get_phase(c);
if (phase >= 0)
- seq_printf(s, "%5d", phase);
+ seq_printf(s, "%-5d", phase);
else
seq_puts(s, "-----");

- seq_printf(s, " %6d", clk_core_get_scaled_duty_cycle(c, 100000));
+ seq_printf(s, " %-6d", clk_core_get_scaled_duty_cycle(c, 100000));

if (c->ops->is_enabled)
- seq_printf(s, " %9c\n", clk_core_is_enabled(c) ? 'Y' : 'N');
+ seq_printf(s, " %5c ", clk_core_is_enabled(c) ? 'Y' : 'N');
else if (!c->ops->enable)
- seq_printf(s, " %9c\n", 'Y');
+ seq_printf(s, " %5c ", 'Y');
else
- seq_printf(s, " %9c\n", '?');
+ seq_printf(s, " %5c ", '?');
+
+ hlist_for_each_entry(clk_user, &c->clks, clks_node) {
+ seq_printf(s, "%*s%-*s %-25s\n",
+ level * 3 + 2 + 105 * multi_node, "",
+ 30,
+ clk_user->dev_id ? clk_user->dev_id : "deviceless",
+ clk_user->con_id ? clk_user->con_id : "no_connection_id");
+
+ multi_node = 1;
+ }
+
}

static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c,
@@ -2994,9 +3007,10 @@ static int clk_summary_show(struct seq_file *s, void *data)
struct clk_core *c;
struct hlist_head **lists = (struct hlist_head **)s->private;

- seq_puts(s, " enable prepare protect duty hardware\n");
- seq_puts(s, " clock count count count rate accuracy phase cycle enable\n");
- seq_puts(s, "-------------------------------------------------------------------------------------------------------\n");
+ seq_puts(s, " enable prepare protect duty hardware connection\n");
+ seq_puts(s, " clock count count count rate accuracy phase cycle enable consumer id\n");
+ seq_puts(s, "---------------------------------------------------------------------------------------------------------------------------------------------\n");
+

clk_prepare_lock();

--
2.7.4


2022-12-10 07:52:49

by <Vishal Badole>

[permalink] [raw]
Subject: Re: [PATCH v5] Common clock: To list active consumers of clocks

Hi Stephen,
We are eagerly waiting for ypur response. As per your suggestions, we have updated and sent another gerrit with message Id
<[email protected]>. In this new patch we are listing the clock consumers name along
with consumer id in clk_summary.

Please review the latest patch.

New patch details:

Message ID:
<[email protected]>
Subject: [PATCH v5] Common clock: To list active consumers of
clocks

Regards,
Vishal

2023-09-07 02:43:19

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v5] Common clock: To list active consumers of clocks

Quoting Maksim Kiselev (2023-08-26 04:25:24)
> Sorry for disturbing. Just a gentle ping :)
> This patch looks abandoned.
> Is there any chance that it will be reviewed?
>

You could review it. Or resend it.

2023-10-24 02:20:36

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v5] Common clock: To list active consumers of clocks

Quoting Vishal Badole (2022-11-27 09:23:19)
> This feature lists the clock consumer's name and respective connection
> id. Using this feature user can easily check that which user has
> acquired and enabled a particular clock.
>
> Usage:
> >> cat /sys/kernel/debug/clk/clk_summary
> enable prepare protect
> duty hardware Connection
> clock count count count rate accuracy phase cycle enable consumer Id
> ------------------------------------------------------------------------------------------------------------------------------
> clk_mcasp0_fixed 0 0 0 24576000 0 0 50000 Y deviceless of_clk_get_from_provider
> deviceless no_connection_id
> clk_mcasp0 0 0 0 24576000 0 0 50000 N simple-audio-card,cpu no_connection_id
> deviceless no_connection_id
>
> Co-developed-by: Chinmoy Ghosh <[email protected]>
> Signed-off-by: Chinmoy Ghosh <[email protected]>
> Co-developed-by: Mintu Patel <[email protected]>
> Signed-off-by: Mintu Patel <[email protected]>
> Co-developed-by: Vimal Kumar <[email protected]>
> Signed-off-by: Vimal Kumar <[email protected]>
> Signed-off-by: Vishal Badole <[email protected]>
> ---

Applied to clk-next