2022-09-15 11:41:50

by Luca Weiss

Subject: [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs

Add more IDs that are found in the downstream msm-4.19 kernel under the
path include/linux/qpnp/qpnp-revid.h.

Signed-off-by: Luca Weiss <[email protected]>
---
Changes since v2:
* Convert hex numbers lowercase
* Remove SMB* IDs added in v1, given it's not sure they're actually spmi
pmics or just i2c pmics (keep SMB2351 because it supports spmi)

include/soc/qcom/qcom-spmi-pmic.h | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h
index fde0148d0077..c47cc71a999e 100644
--- a/include/soc/qcom/qcom-spmi-pmic.h
+++ b/include/soc/qcom/qcom-spmi-pmic.h
@@ -26,6 +26,8 @@
#define PM8901_SUBTYPE 0x0f
#define PM8950_SUBTYPE 0x10
#define PMI8950_SUBTYPE 0x11
+#define PMK8001_SUBTYPE 0x12
+#define PMI8996_SUBTYPE 0x13
#define PM8998_SUBTYPE 0x14
#define PMI8998_SUBTYPE 0x15
#define PM8005_SUBTYPE 0x18
@@ -36,8 +38,17 @@
#define PM8150B_SUBTYPE 0x20
#define PMK8002_SUBTYPE 0x21
#define PM8009_SUBTYPE 0x24
+#define PMI632_SUBTYPE 0x25
#define PM8150C_SUBTYPE 0x26
+#define PM6150_SUBTYPE 0x28
#define SMB2351_SUBTYPE 0x29
+#define PM8008_SUBTYPE 0x2c
+#define PM6125_SUBTYPE 0x2d
+#define PM7250B_SUBTYPE 0x2e
+#define PMK8350_SUBTYPE 0x2f
+#define PMR735B_SUBTYPE 0x34
+#define PM6350_SUBTYPE 0x36
+#define PM2250_SUBTYPE 0x37

#define PMI8998_FAB_ID_SMIC 0x11
#define PMI8998_FAB_ID_GF 0x30
--
2.37.3

2022-09-15 15:08:10

by Dmitry Baryshkov

Subject: Re: [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs

On 15/09/2022 14:35, Luca Weiss wrote:
> Add more IDs that are found in the downstream msm-4.19 kernel under the
> path include/linux/qpnp/qpnp-revid.h.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> Changes since v2:
> * Convert hex numbers lowercase
> * Remove SMB* IDs added in v1, given it's not sure they're actually spmi
> pmics or just i2c pmics (keep SMB2351 because it supports spmi)
>
> include/soc/qcom/qcom-spmi-pmic.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)


Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2022-09-19 12:09:12

by Caleb Connolly

Subject: Re: [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs

On 15/09/2022 12:35, Luca Weiss wrote:
> Add more IDs that are found in the downstream msm-4.19 kernel under the
> path include/linux/qpnp/qpnp-revid.h.
>
> Signed-off-by: Luca Weiss <[email protected]>

Reviewed-by: Caleb Connolly <[email protected]>

Kind Regards,
Caleb
> ---
> Changes since v2:
> * Convert hex numbers lowercase
> * Remove SMB* IDs added in v1, given it's not sure they're actually spmi
> pmics or just i2c pmics (keep SMB2351 because it supports spmi)
>
> include/soc/qcom/qcom-spmi-pmic.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h
> index fde0148d0077..c47cc71a999e 100644
> --- a/include/soc/qcom/qcom-spmi-pmic.h
> +++ b/include/soc/qcom/qcom-spmi-pmic.h
> @@ -26,6 +26,8 @@
> #define PM8901_SUBTYPE 0x0f
> #define PM8950_SUBTYPE 0x10
> #define PMI8950_SUBTYPE 0x11
> +#define PMK8001_SUBTYPE 0x12
> +#define PMI8996_SUBTYPE 0x13
> #define PM8998_SUBTYPE 0x14
> #define PMI8998_SUBTYPE 0x15
> #define PM8005_SUBTYPE 0x18
> @@ -36,8 +38,17 @@
> #define PM8150B_SUBTYPE 0x20
> #define PMK8002_SUBTYPE 0x21
> #define PM8009_SUBTYPE 0x24
> +#define PMI632_SUBTYPE 0x25
> #define PM8150C_SUBTYPE 0x26
> +#define PM6150_SUBTYPE 0x28
> #define SMB2351_SUBTYPE 0x29
> +#define PM8008_SUBTYPE 0x2c
> +#define PM6125_SUBTYPE 0x2d
> +#define PM7250B_SUBTYPE 0x2e
> +#define PMK8350_SUBTYPE 0x2f
> +#define PMR735B_SUBTYPE 0x34
> +#define PM6350_SUBTYPE 0x36
> +#define PM2250_SUBTYPE 0x37
>
> #define PMI8998_FAB_ID_SMIC 0x11
> #define PMI8998_FAB_ID_GF 0x30