2022-01-14 14:16:00

by Marcel Ziswiler

Subject: [PATCH v2 04/11] arm64: defconfig: enable pcieaer configuration

From: Marcel Ziswiler <[email protected]>

Enable CONFIG_PCIEAER which is required for CONFIG_ACPI_APEI_PCIEAER.
Commit 8c8ff55b4da7 ("PCI/AER: Don't select CONFIG_PCIEAER by default")
changed it to no longer being enabled by default.

Signed-off-by: Marcel Ziswiler <[email protected]>

---

Changes in v2:
- New patch following full defconfig analysis as requested by Krzysztof.

arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index dec189229c0a..7daf2de6c31a 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -211,6 +211,7 @@ CONFIG_NFC_NCI=m
CONFIG_NFC_S3FWRN5_I2C=m
CONFIG_PCI=y
CONFIG_PCIEPORTBUS=y
+CONFIG_PCIEAER=y
CONFIG_PCI_IOV=y
CONFIG_PCI_PASID=y
CONFIG_HOTPLUG_PCI=y
--
2.33.1

2022-01-16 06:47:31

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 04/11] arm64: defconfig: enable pcieaer configuration

On 14/01/2022 15:15, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> Enable CONFIG_PCIEAER which is required for CONFIG_ACPI_APEI_PCIEAER.
> Commit 8c8ff55b4da7 ("PCI/AER: Don't select CONFIG_PCIEAER by default")
> changed it to no longer being enabled by default.
>
> Signed-off-by: Marcel Ziswiler <[email protected]>
>
> ---
>
> Changes in v2:
> - New patch following full defconfig analysis as requested by Krzysztof.
>

Good finding! The question is whether we actually need PCIe AER...

Best regards,
Krzysztof

2022-01-17 17:13:56

by Marcel Ziswiler

Subject: Re: [PATCH v2 04/11] arm64: defconfig: enable pcieaer configuration

On Sat, 2022-01-15 at 17:45 +0100, Krzysztof Kozlowski wrote:
> On 14/01/2022 15:15, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <[email protected]>
> >
> > Enable CONFIG_PCIEAER which is required for CONFIG_ACPI_APEI_PCIEAER.
> > Commit 8c8ff55b4da7 ("PCI/AER: Don't select CONFIG_PCIEAER by default")
> > changed it to no longer being enabled by default.
> >
> > Signed-off-by: Marcel Ziswiler <[email protected]>
> >
> > ---
> >
> > Changes in v2:
> > - New patch following full defconfig analysis as requested by Krzysztof.
> >
>
> Good finding! The question is whether we actually need PCIe AER...

Yes, however, why else would we have explicitly enabled CONFIG_ACPI_APEI_PCIEAER?

> Best regards,
> Krzysztof

2022-01-17 17:14:18

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 04/11] arm64: defconfig: enable pcieaer configuration

On 17/01/2022 12:45, Marcel Ziswiler wrote:
> On Sat, 2022-01-15 at 17:45 +0100, Krzysztof Kozlowski wrote:
>> On 14/01/2022 15:15, Marcel Ziswiler wrote:
>>> From: Marcel Ziswiler <[email protected]>
>>>
>>> Enable CONFIG_PCIEAER which is required for CONFIG_ACPI_APEI_PCIEAER.
>>> Commit 8c8ff55b4da7 ("PCI/AER: Don't select CONFIG_PCIEAER by default")
>>> changed it to no longer being enabled by default.
>>>
>>> Signed-off-by: Marcel Ziswiler <[email protected]>
>>>
>>> ---
>>>
>>> Changes in v2:
>>> - New patch following full defconfig analysis as requested by Krzysztof.
>>>
>>
>> Good finding! The question is whether we actually need PCIe AER...
>
> Yes, however, why else would we have explicitly enabled CONFIG_ACPI_APEI_PCIEAER?

Right, I missed that it is mentioned in defconfig.

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof