2022-10-31 11:02:17

by Claudiu Beznea

[permalink] [raw]
Subject: Re: [PATCHv1 0/8] Add support for sam9x60 curiosity board

On 31.10.2022 05:36, Durai Manickam KR wrote:
> This patch series addresses the following:
> - Moving of flexcom definitions from board file to SoC file and
> some minor changes to its properties.
> - Add support for the new sam9x60 curiosity board based on the
> existing sam9x60 SoC.
>
> Changes in v1:

This series is actually v2. Also I cannot locate your patches on
lore.kernel.org don't know why...

> --------------
> - Added generic names for regulator node.
> - Removed the #addredd-cells and #size-cells property which shows
> compilation warning.
> - Removed the property "status=okay" as this is default.
> - No underscores used for the pinctrl definitions and node names.
> - Organised the patches in the logical way.
> - Bindings are made separate pacth.
>
> Durai Manickam KR (5):
> ARM: dts: at91: sam9x60: remove flexcom definitions
> ARM: dts: at91: sam9x60: Add flexcom definitions
> ARM: dts: at91: sam9x60: Add missing flexcom definitions
> dt-bindings: arm: at91: Add info on SAM9X60-CURIOSITY
> ARM: dts: at91: sam9x60_curiosity: Add device tree for
> sam9x60_curiosity board
>
> Hari Prasath (1):
> ARM: dts: at91: sam9x60: Add DMA bindigs for the flexcom nodes
>
> Manikandan M (2):
> ARM: dts: at91: sam9x60: Fix the label numbering for the flexcom
> functions
> ARM: dts: at91: sam9x60: Specify the FIFO size for the Flexcom UART
>
> .../devicetree/bindings/arm/atmel-at91.yaml | 6 +
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/at91-sam9x60_curiosity.dts | 519 +++++++++++++++
> arch/arm/boot/dts/at91-sam9x60ek.dts | 50 +-
> arch/arm/boot/dts/sam9x60.dtsi | 623 ++++++++++++++++++
> 5 files changed, 1159 insertions(+), 40 deletions(-)
> create mode 100644 arch/arm/boot/dts/at91-sam9x60_curiosity.dts
>


2022-11-02 20:49:00

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCHv1 0/8] Add support for sam9x60 curiosity board

On 31/10/2022 06:20, [email protected] wrote:
> On 31.10.2022 05:36, Durai Manickam KR wrote:
>> This patch series addresses the following:
>> - Moving of flexcom definitions from board file to SoC file and
>> some minor changes to its properties.
>> - Add support for the new sam9x60 curiosity board based on the
>> existing sam9x60 SoC.
>>
>> Changes in v1:
>
> This series is actually v2. Also I cannot locate your patches on
> lore.kernel.org don't know why...
>

I was not cced on this submission - I got only reply from yours. As you
pointed out this v1 which is v2 ignores several of my comments.

Best regards,
Krzysztof


2022-11-03 05:55:07

by Durai Manickam KR

[permalink] [raw]
Subject: Re: [PATCHv1 0/8] Add support for sam9x60 curiosity board

On 03/11/22 01:48, Krzysztof Kozlowski wrote:
> [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 31/10/2022 06:20, [email protected] wrote:
>> On 31.10.2022 05:36, Durai Manickam KR wrote:
>>> This patch series addresses the following:
>>> - Moving of flexcom definitions from board file to SoC file and
>>> some minor changes to its properties.
>>> - Add support for the new sam9x60 curiosity board based on the
>>> existing sam9x60 SoC.
>>>
>>> Changes in v1:
>> This series is actually v2. Also I cannot locate your patches on
>> lore.kernel.org don't know why...
>>
> I was not cced on this submission - I got only reply from yours. As you
> pointed out this v1 which is v2 ignores several of my comments.
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,

I will address all the comments received  and will send as patch v3.