2022-08-12 12:40:23

by Martin Liška

Subject: [PATCH] perf: fix coding style in build-id.c

Use tabs instead of 8 spaces for the indentation.

Signed-off-by: Martin Liska <[email protected]>
---
tools/perf/util/build-id.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
index 9e176146eb10..0cc68cdd84c8 100644
--- a/tools/perf/util/build-id.c
+++ b/tools/perf/util/build-id.c
@@ -652,17 +652,17 @@ static char *build_id_cache__find_debug(const char *sbuild_id,
nsinfo__mountns_exit(&nsc);

#ifdef HAVE_DEBUGINFOD_SUPPORT
- if (realname == NULL) {
- debuginfod_client* c = debuginfod_begin();
- if (c != NULL) {
- int fd = debuginfod_find_debuginfo(c,
- (const unsigned char*)sbuild_id, 0,
- &realname);
- if (fd >= 0)
- close(fd); /* retaining reference by realname */
- debuginfod_end(c);
- }
- }
+ if (realname == NULL) {
+ debuginfod_client* c = debuginfod_begin();
+ if (c != NULL) {
+ int fd = debuginfod_find_debuginfo(c,
+ (const unsigned char*)sbuild_id, 0,
+ &realname);
+ if (fd >= 0)
+ close(fd); /* retaining reference by realname */
+ debuginfod_end(c);
+ }
+ }
#endif

out:
--
2.37.1

2022-08-12 13:49:56

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf: fix coding style in build-id.c

Em Fri, Aug 12, 2022 at 01:42:56PM +0200, Martin Liška escreveu:
> Use tabs instead of 8 spaces for the indentation.

Thanks, applied.

- Arnaldo


> Signed-off-by: Martin Liska <[email protected]>
> ---
> tools/perf/util/build-id.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
> index 9e176146eb10..0cc68cdd84c8 100644
> --- a/tools/perf/util/build-id.c
> +++ b/tools/perf/util/build-id.c
> @@ -652,17 +652,17 @@ static char *build_id_cache__find_debug(const char *sbuild_id,
> nsinfo__mountns_exit(&nsc);
>
> #ifdef HAVE_DEBUGINFOD_SUPPORT
> - if (realname == NULL) {
> - debuginfod_client* c = debuginfod_begin();
> - if (c != NULL) {
> - int fd = debuginfod_find_debuginfo(c,
> - (const unsigned char*)sbuild_id, 0,
> - &realname);
> - if (fd >= 0)
> - close(fd); /* retaining reference by realname */
> - debuginfod_end(c);
> - }
> - }
> + if (realname == NULL) {
> + debuginfod_client* c = debuginfod_begin();
> + if (c != NULL) {
> + int fd = debuginfod_find_debuginfo(c,
> + (const unsigned char*)sbuild_id, 0,
> + &realname);
> + if (fd >= 0)
> + close(fd); /* retaining reference by realname */
> + debuginfod_end(c);
> + }
> + }
> #endif
>
> out:
> --
> 2.37.1

--

- Arnaldo