2001-12-08 02:45:59

by Rich Baum

[permalink] [raw]
Subject: [PATCH][RFC] Allow drivers/scsi/imm.c to compile in 2.5.1pre6

The attached patch fixes compile errors in imm.c in 2.5.1pre6. At boot it
will detect the drive however if a disk is in the drive I get an oops (see
oops1.log). If there is no disk it will boot just fine.

When I run 'eject /dev/sda' after I insert a disk in the drive I get an oops
(see oops2.log).

Please give me some feedback on what can be done to fix these problems. I
can also do other tests and provide more information if need.

Thanks,
Rich


Attachments:
imm.diff (1.26 kB)
oops1.log (2.49 kB)
oops2.log (2.50 kB)
Download all attachments

2001-12-08 14:02:51

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH][RFC] Allow drivers/scsi/imm.c to compile in 2.5.1pre6

On Fri, Dec 07 2001, Rich Baum wrote:
> The attached patch fixes compile errors in imm.c in 2.5.1pre6. At boot it
> will detect the drive however if a disk is in the drive I get an oops (see
> oops1.log). If there is no disk it will boot just fine.

Two problems:

- detect() is not run with lock held anymore
- use of ->address is deprecated

Please try attached patch -- it's a quickie, so no guarentees :-)

--
Jens Axboe


Attachments:
(No filename) (431.00 B)
imm-1 (2.33 kB)
Download all attachments

2001-12-08 14:07:07

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH][RFC] Allow drivers/scsi/imm.c to compile in 2.5.1pre6

On Sat, Dec 08 2001, Jens Axboe wrote:
> Two problems:
>
> - detect() is not run with lock held anymore
> - use of ->address is deprecated

Actually a third one too that is also right in my patch but I neglected
to mention -- don't rely on using cmd->host _after_ having called
->scsi_done() on this command.

--
Jens Axboe