2017-06-28 13:07:05

by Colin King

Subject: [PATCH][iio-next] iio: adc: stm32: make array stm32h7_adc_ckmodes_spec static

From: Colin Ian King <[email protected]>

The array stm32h7_adc_ckmodes_spec does not need to be in global scope, so
make it static.

Cleans up sparse warning:
"symbol 'stm32h7_adc_ckmodes_spec' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/iio/adc/stm32-adc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
index e09233b03c05..9d083c2338f9 100644
--- a/drivers/iio/adc/stm32-adc-core.c
+++ b/drivers/iio/adc/stm32-adc-core.c
@@ -172,7 +172,7 @@ struct stm32h7_adc_ck_spec {
int div;
};

-const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
+static const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
/* 00: CK_ADC[1..3]: Asynchronous clock modes */
{ 0, 0, 1 },
{ 0, 1, 2 },
--
2.11.0

2017-06-28 14:36:01

by Fabrice Gasnier

Subject: Re: [PATCH][iio-next] iio: adc: stm32: make array stm32h7_adc_ckmodes_spec static

On 06/28/2017 03:06 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The array stm32h7_adc_ckmodes_spec does not need to be in global scope, so
> make it static.
>
> Cleans up sparse warning:
> "symbol 'stm32h7_adc_ckmodes_spec' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/iio/adc/stm32-adc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index e09233b03c05..9d083c2338f9 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -172,7 +172,7 @@ struct stm32h7_adc_ck_spec {
> int div;
> };
>
> -const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
> +static const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
> /* 00: CK_ADC[1..3]: Asynchronous clock modes */
> { 0, 0, 1 },
> { 0, 1, 2 },
>
Acked-by: Fabrice Gasnier <[email protected]>

2017-07-01 10:14:36

by Jonathan Cameron

Subject: Re: [PATCH][iio-next] iio: adc: stm32: make array stm32h7_adc_ckmodes_spec static

On Wed, 28 Jun 2017 16:35:04 +0200
Fabrice Gasnier <[email protected]> wrote:

> On 06/28/2017 03:06 PM, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > The array stm32h7_adc_ckmodes_spec does not need to be in global scope, so
> > make it static.
> >
> > Cleans up sparse warning:
> > "symbol 'stm32h7_adc_ckmodes_spec' was not declared. Should it be static?"
> >
> > Signed-off-by: Colin Ian King <[email protected]>
> > ---
> > drivers/iio/adc/stm32-adc-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> > index e09233b03c05..9d083c2338f9 100644
> > --- a/drivers/iio/adc/stm32-adc-core.c
> > +++ b/drivers/iio/adc/stm32-adc-core.c
> > @@ -172,7 +172,7 @@ struct stm32h7_adc_ck_spec {
> > int div;
> > };
> >
> > -const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
> > +static const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
> > /* 00: CK_ADC[1..3]: Asynchronous clock modes */
> > { 0, 0, 1 },
> > { 0, 1, 2 },
> >
> Acked-by: Fabrice Gasnier <[email protected]>
applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html