2022-05-26 01:44:29

by Karsten Graul

[permalink] [raw]
Subject: Re: [PATCH net] net/smc: set ini->smcrv2.ib_dev_v2 to NULL if SMC-Rv2 is unavailable

On 25/05/2022 10:54, [email protected] wrote:
> From: liuyacan <[email protected]>
>
> In the process of checking whether RDMAv2 is available, the current
> implementation first sets ini->smcrv2.ib_dev_v2, and then allocates
> smc buf desc and register rmb, but the latter may fail. In this case,
> the pointer should be reset.
>
> Fixes: e49300a6bf62 ("net/smc: add listen processing for SMC-Rv2")
> Signed-off-by: liuyacan <[email protected]>
> ---
> net/smc/af_smc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 45a24d242..540b32d86 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -2136,6 +2136,7 @@ static void smc_find_rdma_v2_device_serv(struct smc_sock *new_smc,
>
> not_found:
> ini->smcr_version &= ~SMC_V2;
> + ini->smcrv2.ib_dev_v2 = NULL;
> ini->check_smcrv2 = false;
> }
>

Thank you!

Reviewed-by: Karsten Graul <[email protected]>