2017-08-10 16:28:08

by Amitoj Kaur Chawla

Subject: [PATCH 1/2] leds: blinkm: constify attribute_group structure

Functions working with attribute_groups provided by <linux/sysfs.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.

File size before:
text data bss dec hex filename
8657 3496 64 12217 2fb9 drivers/leds/leds-blinkm.o

File size after:
text data bss dec hex filename
8753 3400 64 12217 2fb9 drivers/leds/leds-blinkm.o

This change was made with the help of Coccinelle.

Signed-off-by: Amitoj Kaur Chawla <[email protected]>
---
drivers/leds/leds-blinkm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
index 617fe97..d03ed6b 100644
--- a/drivers/leds/leds-blinkm.c
+++ b/drivers/leds/leds-blinkm.c
@@ -298,7 +298,7 @@ static struct attribute *blinkm_attrs[] = {
NULL,
};

-static struct attribute_group blinkm_group = {
+static const struct attribute_group blinkm_group = {
.name = "blinkm",
.attrs = blinkm_attrs,
};
--
2.7.4

2017-08-14 20:48:17

by Jacek Anaszewski

Subject: Re: [PATCH 1/2] leds: blinkm: constify attribute_group structure

Hi Amitoj,

Similar patch is already queued in the for-next branch
of linux-leds.git.

Thanks,
Jacek Anaszewski

On 08/10/2017 06:28 PM, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/sysfs.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 8657 3496 64 12217 2fb9 drivers/leds/leds-blinkm.o
>
> File size after:
> text data bss dec hex filename
> 8753 3400 64 12217 2fb9 drivers/leds/leds-blinkm.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <[email protected]>
> ---
> drivers/leds/leds-blinkm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
> index 617fe97..d03ed6b 100644
> --- a/drivers/leds/leds-blinkm.c
> +++ b/drivers/leds/leds-blinkm.c
> @@ -298,7 +298,7 @@ static struct attribute *blinkm_attrs[] = {
> NULL,
> };
>
> -static struct attribute_group blinkm_group = {
> +static const struct attribute_group blinkm_group = {
> .name = "blinkm",
> .attrs = blinkm_attrs,
> };
>