2020-06-09 03:55:20

by Y Paritcher

Subject: [PATCH v3 1/3] platform/x86: dell-wmi: add new backlight events

Add events with a type of 0x0010 and a code of 0x57 / 0x58,
this silences the following messages being logged on a
Dell Inspiron 5593:

dell_wmi: Unknown key with type 0x0010 and code 0x0057 pressed
dell_wmi: Unknown key with type 0x0010 and code 0x0058 pressed

These are brightness events and will be handled by acpi-video

Signed-off-by: Y Paritcher <[email protected]>
---
drivers/platform/x86/dell-wmi.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index c25a4286d766..0b2edfe2767d 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -255,6 +255,10 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
/* Keyboard backlight change notification */
{ KE_IGNORE, 0x3f, { KEY_RESERVED } },

+ /* Backlight brightness level */
+ { KE_KEY, 0x57, { KEY_BRIGHTNESSDOWN } },
+ { KE_KEY, 0x58, { KEY_BRIGHTNESSUP } },
+
/* Mic mute */
{ KE_KEY, 0x150, { KEY_MICMUTE } },

--
2.27.0

2020-06-09 17:50:46

by Mario Limonciello

Subject: RE: [PATCH v3 1/3] platform/x86: dell-wmi: add new backlight events

> -----Original Message-----
> From: Y Paritcher <[email protected]>
> Sent: Monday, June 8, 2020 10:53 PM
> To: Pali Roh?r
> Cc: [email protected]; [email protected];
> Matthew Garrett; Limonciello, Mario
> Subject: [PATCH v3 1/3] platform/x86: dell-wmi: add new backlight events
>
>
> [EXTERNAL EMAIL]
>
> Add events with a type of 0x0010 and a code of 0x57 / 0x58,
> this silences the following messages being logged on a
> Dell Inspiron 5593:
>
> dell_wmi: Unknown key with type 0x0010 and code 0x0057 pressed
> dell_wmi: Unknown key with type 0x0010 and code 0x0058 pressed
>
> These are brightness events and will be handled by acpi-video
>
> Signed-off-by: Y Paritcher <[email protected]>

Reviewed-by: Mario Limonciello <[email protected]>

> ---
> drivers/platform/x86/dell-wmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-
> wmi.c
> index c25a4286d766..0b2edfe2767d 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -255,6 +255,10 @@ static const struct key_entry
> dell_wmi_keymap_type_0010[] = {
> /* Keyboard backlight change notification */
> { KE_IGNORE, 0x3f, { KEY_RESERVED } },
>
> + /* Backlight brightness level */
> + { KE_KEY, 0x57, { KEY_BRIGHTNESSDOWN } },
> + { KE_KEY, 0x58, { KEY_BRIGHTNESSUP } },
> +
> /* Mic mute */
> { KE_KEY, 0x150, { KEY_MICMUTE } },
>
> --
> 2.27.0