Hello Olof,
Please pull PCIe updates for ST's SPEAr1310 SoC.
Last version of posted V8 patches have been Acked-by respective maintainers.
https://lkml.org/lkml/2014/4/15/260
Apart from arch/arm/ changes, it also contains patches for drivers/{pci|phy}.
Bjorn advised to get complete series via arm-soc tree.
http://www.spinics.net/lists/linux-pci/msg30271.html
Regards
Mohit
The following changes since commit 4c834452aad01531db949414f94f817a86348d59:
Linus Torvalds (1):
Linux 3.16-rc3
are available in the git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/linux.git spear/pcie-support-v8
Mohit Kumar (1):
SPEAr13xx: defconfig: Update
Pratyush Anand (8):
clk: SPEAr13XX: Fix pcie clock name
SPEAr13XX: Fix static mapping table
phy: SPEAr1310/40-miphy: Add binding information
SPEAr: misc: Add binding information
phy: SPEAr1310/40-miphy: Add phy driver for PCIe and SATA
SPEAr13XX: Add binding information for PCIe controller
SPEAr13XX: dts: Add PCIe node information
pcie: SPEAr13xx: Add designware wrapper support
.../devicetree/bindings/arm/spear-misc.txt | 9 +
.../devicetree/bindings/pci/spear13xx-pcie.txt | 14 +
.../devicetree/bindings/phy/st-spear1310-miphy.txt | 12 +
.../devicetree/bindings/phy/st-spear1340-miphy.txt | 11 +
MAINTAINERS | 6 +
arch/arm/boot/dts/spear1310-evb.dts | 4 +
arch/arm/boot/dts/spear1310.dtsi | 93 +++++-
arch/arm/boot/dts/spear1340-evb.dts | 4 +
arch/arm/boot/dts/spear1340.dtsi | 30 ++-
arch/arm/boot/dts/spear13xx.dtsi | 9 +-
arch/arm/configs/spear13xx_defconfig | 16 +
arch/arm/mach-spear/Kconfig | 4 +
arch/arm/mach-spear/include/mach/spear.h | 4 +-
arch/arm/mach-spear/spear1340.c | 127 +------
arch/arm/mach-spear/spear13xx.c | 2 +-
drivers/clk/spear/spear1310_clock.c | 6 +-
drivers/clk/spear/spear1340_clock.c | 2 +-
drivers/pci/host/Kconfig | 8 +
drivers/pci/host/Makefile | 1 +
drivers/pci/host/pcie-spear13xx.c | 406 ++++++++++++++++++++
drivers/phy/Kconfig | 12 +
drivers/phy/Makefile | 2 +
drivers/phy/phy-spear1310-miphy.c | 274 +++++++++++++
drivers/phy/phy-spear1340-miphy.c | 300 +++++++++++++++
24 files changed, 1217 insertions(+), 139 deletions(-)
create mode 100644 Documentation/devicetree/bindings/arm/spear-misc.txt
create mode 100644 Documentation/devicetree/bindings/pci/spear13xx-pcie.txt
create mode 100644 Documentation/devicetree/bindings/phy/st-spear1310-miphy.txt
create mode 100644 Documentation/devicetree/bindings/phy/st-spear1340-miphy.txt
create mode 100644 drivers/pci/host/pcie-spear13xx.c
create mode 100644 drivers/phy/phy-spear1310-miphy.c
create mode 100644 drivers/phy/phy-spear1340-miphy.c
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
+ [email protected]
Sorry for previous mail addressed to Olof's personal id.
Thanks
Mohit
> -----Original Message-----
> From: Mohit KUMAR DCG
> Sent: Wednesday, July 09, 2014 11:18 AM
> To: [email protected]
> Cc: Bartlomiej Zolnierkiewicz; Pratyush ANAND; 'Bjorn Helgaas'
> ([email protected]); spear-devel; [email protected];
> [email protected]; [email protected]; Mark Nicholson;
> Viresh Kumar
> Subject: [GIT PULL] ARM: SPEAr1310 PCIe updates
>
> Hello Olof,
>
> Please pull PCIe updates for ST's SPEAr1310 SoC.
>
> Last version of posted V8 patches have been Acked-by respective
> maintainers.
> https://lkml.org/lkml/2014/4/15/260
>
> Apart from arch/arm/ changes, it also contains patches for drivers/{pci|phy}.
> Bjorn advised to get complete series via arm-soc tree.
> http://www.spinics.net/lists/linux-pci/msg30271.html
>
> Regards
> Mohit
>
> The following changes since commit
> 4c834452aad01531db949414f94f817a86348d59:
> Linus Torvalds (1):
> Linux 3.16-rc3
>
> are available in the git repository at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/linux.git
> spear/pcie-support-v8
>
> Mohit Kumar (1):
> SPEAr13xx: defconfig: Update
>
> Pratyush Anand (8):
> clk: SPEAr13XX: Fix pcie clock name
> SPEAr13XX: Fix static mapping table
> phy: SPEAr1310/40-miphy: Add binding information
> SPEAr: misc: Add binding information
> phy: SPEAr1310/40-miphy: Add phy driver for PCIe and SATA
> SPEAr13XX: Add binding information for PCIe controller
> SPEAr13XX: dts: Add PCIe node information
> pcie: SPEAr13xx: Add designware wrapper support
>
> .../devicetree/bindings/arm/spear-misc.txt | 9 +
> .../devicetree/bindings/pci/spear13xx-pcie.txt | 14 +
> .../devicetree/bindings/phy/st-spear1310-miphy.txt | 12 +
> .../devicetree/bindings/phy/st-spear1340-miphy.txt | 11 +
> MAINTAINERS | 6 +
> arch/arm/boot/dts/spear1310-evb.dts | 4 +
> arch/arm/boot/dts/spear1310.dtsi | 93 +++++-
> arch/arm/boot/dts/spear1340-evb.dts | 4 +
> arch/arm/boot/dts/spear1340.dtsi | 30 ++-
> arch/arm/boot/dts/spear13xx.dtsi | 9 +-
> arch/arm/configs/spear13xx_defconfig | 16 +
> arch/arm/mach-spear/Kconfig | 4 +
> arch/arm/mach-spear/include/mach/spear.h | 4 +-
> arch/arm/mach-spear/spear1340.c | 127 +------
> arch/arm/mach-spear/spear13xx.c | 2 +-
> drivers/clk/spear/spear1310_clock.c | 6 +-
> drivers/clk/spear/spear1340_clock.c | 2 +-
> drivers/pci/host/Kconfig | 8 +
> drivers/pci/host/Makefile | 1 +
> drivers/pci/host/pcie-spear13xx.c | 406 ++++++++++++++++++++
> drivers/phy/Kconfig | 12 +
> drivers/phy/Makefile | 2 +
> drivers/phy/phy-spear1310-miphy.c | 274 +++++++++++++
> drivers/phy/phy-spear1340-miphy.c | 300 +++++++++++++++
> 24 files changed, 1217 insertions(+), 139 deletions(-) create mode 100644
> Documentation/devicetree/bindings/arm/spear-misc.txt
> create mode 100644 Documentation/devicetree/bindings/pci/spear13xx-
> pcie.txt
> create mode 100644 Documentation/devicetree/bindings/phy/st-
> spear1310-miphy.txt
> create mode 100644 Documentation/devicetree/bindings/phy/st-
> spear1340-miphy.txt
> create mode 100644 drivers/pci/host/pcie-spear13xx.c create mode 100644
> drivers/phy/phy-spear1310-miphy.c create mode 100644 drivers/phy/phy-
> spear1340-miphy.c
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
Hi,
On Tue, Jul 8, 2014 at 10:48 PM, Mohit KUMAR DCG <[email protected]> wrote:
> Hello Olof,
>
> Please pull PCIe updates for ST's SPEAr1310 SoC.
>
> Last version of posted V8 patches have been Acked-by respective maintainers.
> https://lkml.org/lkml/2014/4/15/260
>
> Apart from arch/arm/ changes, it also contains patches for drivers/{pci|phy}.
> Bjorn advised to get complete series via arm-soc tree.
> http://www.spinics.net/lists/linux-pci/msg30271.html
>
> Regards
> Mohit
>
> The following changes since commit 4c834452aad01531db949414f94f817a86348d59:
> Linus Torvalds (1):
> Linux 3.16-rc3
>
> are available in the git repository at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/linux.git spear/pcie-support-v8
>
> Mohit Kumar (1):
> SPEAr13xx: defconfig: Update
>
> Pratyush Anand (8):
> clk: SPEAr13XX: Fix pcie clock name
> SPEAr13XX: Fix static mapping table
> phy: SPEAr1310/40-miphy: Add binding information
> SPEAr: misc: Add binding information
> phy: SPEAr1310/40-miphy: Add phy driver for PCIe and SATA
> SPEAr13XX: Add binding information for PCIe controller
> SPEAr13XX: dts: Add PCIe node information
> pcie: SPEAr13xx: Add designware wrapper support
There are so many things wrong with this pull request.
* Why is this not coming from the spear maintainer that knows how to
look at patches and deal with these things?
* Why have you separated out the PCIe node info, but not the phy DTS
updates in separate patches?
* Why are you sending a pull request for a repo that is not yours?
* Why is Viresh the git committer but hasn't signed off on the patches?
Are you sharing accounts on kernel.org? (Adding kernel.org admin on cc
just in case).
I'm not going to touch this pull request until the above has been
sorted out and explained.
-Olof
On 9 July 2014 23:39, Olof Johansson <[email protected]> wrote:
> * Why are you sending a pull request for a repo that is not yours?
Because Mohit/Pratyush were facing some issues in pushing patches
to the SPEAr public git repo. And so I tried to help them out publicly
and nobody objected then:
https://lkml.org/lkml/2014/7/8/10
> * Why is Viresh the git committer but hasn't signed off on the patches?
I didn't sign-off because I haven't even looked closed at many of the
patches around PCI and Acked whatever I could understand.
But yeah, this committer thing is what I missed. Because of that I might
be required to signoff it.
> Are you sharing accounts on kernel.org? (Adding kernel.org admin on cc
> just in case).
Obviously not. I am alone the user of this account.
On Wed, Jul 9, 2014 at 5:18 PM, Viresh Kumar <[email protected]> wrote:
> On 9 July 2014 23:39, Olof Johansson <[email protected]> wrote:
>> * Why are you sending a pull request for a repo that is not yours?
>
> Because Mohit/Pratyush were facing some issues in pushing patches
> to the SPEAr public git repo. And so I tried to help them out publicly
> and nobody objected then:
>
> https://lkml.org/lkml/2014/7/8/10
This is completely done wrong on so many levels.
I am not going to merge code from someone who doesn't have the basic
skills down when there's already a maintainer for the platform.
Luckily, you can deal with it -- be it coaching the ST employees on
how to work with the community the right way, or doing the work
yourself to send the code up. Probably a combination in this case.
>> * Why is Viresh the git committer but hasn't signed off on the patches?
>
> I didn't sign-off because I haven't even looked closed at many of the
> patches around PCI and Acked whatever I could understand.
Thanks, good to know that the series hasn't been fully reviewed. That
makes me even more hesitant to apply it at the moment, given all the
other issues around it.
> But yeah, this committer thing is what I missed. Because of that I might
> be required to signoff it.
Anyone touching the patch, forwarding it or applying it needs to sign
off. It's quite simple, and well documented.
>> Are you sharing accounts on kernel.org? (Adding kernel.org admin on cc
>> just in case).
>
> Obviously not. I am alone the user of this account.
Good.
-Olof
On 10 July 2014 10:47, Olof Johansson <[email protected]> wrote:
>> I didn't sign-off because I haven't even looked closed at many of the
>> patches around PCI and Acked whatever I could understand.
>
> Thanks, good to know that the series hasn't been fully reviewed. That
> makes me even more hesitant to apply it at the moment, given all the
> other issues around it.
Its not that the series hasn't been fully reviewed, it is.
Arnd has reviewed and Acked the complete series. I have Acked SPEAr
specific parts and Bjorn have Acked PCI specific stuff.
>> But yeah, this committer thing is what I missed. Because of that I might
>> be required to signoff it.
>
> Anyone touching the patch, forwarding it or applying it needs to sign
> off. It's quite simple, and well documented.
Yeah, my mistake. Accepted.