2018-08-08 15:14:22

by zhong jiang

Subject: [PATCH] drivers/block/aoe/aoedev: NULL check is not needed for mempool_destroy

mempool_destroy has taken the null pointer into account. So it is safe
to remove the null check.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/block/aoe/aoedev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index 697f735..41060e9 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -284,8 +284,8 @@
e = t + d->ntargets;
for (; t < e && *t; t++)
freetgt(d, *t);
- if (d->bufpool)
- mempool_destroy(d->bufpool);
+
+ mempool_destroy(d->bufpool);
skbpoolfree(d);
minor_free(d->sysminor);

--
1.7.12.4

2018-08-08 15:18:38

by Jens Axboe

Subject: Re: [PATCH] drivers/block/aoe/aoedev: NULL check is not needed for mempool_destroy

On 8/8/18 9:00 AM, zhong jiang wrote:
> mempool_destroy has taken the null pointer into account. So it is safe
> to remove the null check.

Applied, thanks.

--
Jens Axboe