2021-09-28 19:17:25

by Mianhan Liu

Subject: [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c

ht16k33.c hasn't use any macro or function declared in linux/slab.h.
Thus, these files can be removed from ht16k33.c safely without
affecting the compilation of the drivers/auxdisplay/ module

Signed-off-by: Mianhan Liu <[email protected]>

---
drivers/auxdisplay/ht16k33.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index 1e69cc6d2..6502bc00e 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -13,7 +13,6 @@
#include <linux/i2c.h>
#include <linux/of.h>
#include <linux/fb.h>
-#include <linux/slab.h>
#include <linux/backlight.h>
#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
--
2.25.1

2021-09-30 06:41:56

by Robin van der Gracht

Subject: Re: [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c

On 2021-09-28 21:15, Mianhan Liu wrote:
> ht16k33.c hasn't use any macro or function declared in linux/slab.h.
> Thus, these files can be removed from ht16k33.c safely without
> affecting the compilation of the drivers/auxdisplay/ module
>
> Signed-off-by: Mianhan Liu <[email protected]>
>
> ---
> drivers/auxdisplay/ht16k33.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
> index 1e69cc6d2..6502bc00e 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -13,7 +13,6 @@
> #include <linux/i2c.h>
> #include <linux/of.h>
> #include <linux/fb.h>
> -#include <linux/slab.h>
> #include <linux/backlight.h>
> #include <linux/input.h>
> #include <linux/input/matrix_keypad.h>

Acked-by: Robin van der Gracht <[email protected]>

2021-10-21 22:12:32

by Miguel Ojeda

Subject: Re: [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c

On Tue, Sep 28, 2021 at 9:15 PM Mianhan Liu <[email protected]> wrote:
>
> ht16k33.c hasn't use any macro or function declared in linux/slab.h.
> Thus, these files can be removed from ht16k33.c safely without
> affecting the compilation of the drivers/auxdisplay/ module

Applied, thanks!

Cheers,
Miguel