2021-09-09 08:54:22

by Bixuan Cui

Subject: [PATCH -next] io-wq: Fix memory leak in create_io_worker

If io_should_retry_thread is false, free the worker before goto fails.

Fixes: 3146cba99aa2 ("io-wq: make worker creation resilient against signals")
Reported-by: [email protected]
Signed-off-by: Bixuan Cui <[email protected]>
---
fs/io-wq.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/io-wq.c b/fs/io-wq.c
index d80e4a735677..036953f334d4 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -759,6 +759,7 @@ static bool create_io_worker(struct io_wq *wq, struct io_wqe *wqe, int index)
if (!IS_ERR(tsk)) {
io_init_new_worker(wqe, worker, tsk);
} else if (!io_should_retry_thread(PTR_ERR(tsk))) {
+ kfree(worker);
goto fail;
} else {
INIT_WORK(&worker->work, io_workqueue_create);
--
2.17.1

2021-09-09 14:26:56

by Jens Axboe

Subject: Re: [PATCH -next] io-wq: Fix memory leak in create_io_worker

On 9/9/21 2:49 AM, Bixuan Cui wrote:
> If io_should_retry_thread is false, free the worker before goto fails.

This one is incomplete, see other postings.

--
Jens Axboe