2023-01-06 11:54:51

by Matti Lehtimäki

[permalink] [raw]
Subject: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks

Document the general purpose clock functions that are found on MSM8226.

Signed-off-by: Matti Lehtimäki <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
index 3b79f5be860b..6e3808065845 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
@@ -66,8 +66,8 @@ $defs:
enum: [ gpio, cci_i2c0, blsp_uim1, blsp_uim2, blsp_uim3, blsp_uim5,
blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_spi1,
blsp_spi2, blsp_spi3, blsp_spi5, blsp_uart1, blsp_uart2,
- blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, sdc3,
- wlan ]
+ blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1,
+ gp0_clk, gp1_clk, sdc3, wlan ]

bias-pull-down: true
bias-pull-up: true
--
2.34.1


2023-01-06 12:41:51

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks

On 06/01/2023 12:44, Matti Lehtimäki wrote:
> Document the general purpose clock functions that are found on MSM8226.
>
> Signed-off-by: Matti Lehtimäki <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
> index 3b79f5be860b..6e3808065845 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
> @@ -66,8 +66,8 @@ $defs:
> enum: [ gpio, cci_i2c0, blsp_uim1, blsp_uim2, blsp_uim3, blsp_uim5,
> blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_spi1,
> blsp_spi2, blsp_spi3, blsp_spi5, blsp_uart1, blsp_uart2,
> - blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, sdc3,
> - wlan ]
> + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1,
> + gp0_clk, gp1_clk, sdc3, wlan ]

Driver does not support them (and there is no driver change, unless you
cc-ed people selectively...).

Best regards,
Krzysztof

2023-01-06 12:54:13

by Matti Lehtimäki

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks

On 6.1.2023 14.32, Krzysztof Kozlowski wrote:
> On 06/01/2023 12:44, Matti Lehtimäki wrote:
>> + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0,
>> cam_mclk1, + gp0_clk, gp1_clk, sdc3, wlan ]
>
> Driver does not support them (and there is no driver change, unless
> you cc-ed people selectively...).

The driver changes are in patch number 2 of the series, I used
git send-mail with a cc script, which uses get_maintainer.pl to
get the needed addresses for each patch, to send the patches. It
probably didn't send every patch to everyone and would need some
improvement.

-Matti


2023-01-06 13:18:49

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks

On 06/01/2023 12:44, Matti Lehtimäki wrote:
> Document the general purpose clock functions that are found on MSM8226.
>
> Signed-off-by: Matti Lehtimäki <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-01-06 13:20:32

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks

On 06/01/2023 13:41, Matti Lehtimäki wrote:
> On 6.1.2023 14.32, Krzysztof Kozlowski wrote:
>> On 06/01/2023 12:44, Matti Lehtimäki wrote:
>>> + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0,
>>> cam_mclk1, + gp0_clk, gp1_clk, sdc3, wlan ]
>>
>> Driver does not support them (and there is no driver change, unless
>> you cc-ed people selectively...).
>
> The driver changes are in patch number 2 of the series, I used
> git send-mail with a cc script, which uses get_maintainer.pl to
> get the needed addresses for each patch, to send the patches. It
> probably didn't send every patch to everyone and would need some
> improvement.

Ah, ok, such method is recommended for big patchsets. In regular cases
please Cc everyone for all patches. I am using this one:

https://pastebin.com/HAjuht68

Best regards,
Krzysztof

2023-01-10 08:37:50

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks

On Fri, Jan 6, 2023 at 12:44 PM Matti Lehtimäki
<[email protected]> wrote:

> Document the general purpose clock functions that are found on MSM8226.
>
> Signed-off-by: Matti Lehtimäki <[email protected]>

Patch applied!

Yours,
Linus Walleij