In preparation to enabling -Wimplicit-fallthrough, this patchset aims
to mark switch cases where we are expecting to fall through.
Thanks!
Gustavo A. R. Silva (7):
ASoC: msm8916-wcd-analog: mark expected switch fall-through
ASoC: tlv320aic23: mark expected switch fall-through
ASoC: tlv320dac31xx: mark expected switch fall-through
ASoC: tpa6130a2: mark expected switch fall-through
ASoC: wm8753: mark expected switch fall-throughs
ASoC: wm8993: mark expected switch fall-throughs
ASoC: wm8994: mark expected switch fall-throughs
sound/soc/codecs/msm8916-wcd-analog.c | 1 +
sound/soc/codecs/tlv320aic23.c | 1 +
sound/soc/codecs/tlv320aic31xx.c | 2 +-
sound/soc/codecs/tpa6130a2.c | 1 +
sound/soc/codecs/wm8753.c | 4 ++--
sound/soc/codecs/wm8993.c | 2 ++
sound/soc/codecs/wm8994.c | 2 ++
7 files changed, 10 insertions(+), 3 deletions(-)
--
2.7.4
From 1583509376077038365@xxx Wed Nov 08 14:43:41 +0000 2017
X-GM-THRID: 1583410056848297381
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 115164
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
sound/soc/codecs/tpa6130a2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
index 2e014c8..616cd4b 100644
--- a/sound/soc/codecs/tpa6130a2.c
+++ b/sound/soc/codecs/tpa6130a2.c
@@ -274,6 +274,7 @@ static int tpa6130a2_probe(struct i2c_client *client,
default:
dev_warn(dev, "Unknown TPA model (%d). Assuming 6130A2\n",
data->id);
+ /* fall through */
case TPA6130A2:
regulator = "Vdd";
break;
--
2.7.4
From 1583499476497079546@xxx Wed Nov 08 12:06:20 +0000 2017
X-GM-THRID: 1582421855965069662
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 115168
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
sound/soc/codecs/wm8993.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/wm8993.c b/sound/soc/codecs/wm8993.c
index 195f7bf..830ffd80 100644
--- a/sound/soc/codecs/wm8993.c
+++ b/sound/soc/codecs/wm8993.c
@@ -1076,6 +1076,7 @@ static int wm8993_set_sysclk(struct snd_soc_dai *codec_dai,
switch (clk_id) {
case WM8993_SYSCLK_MCLK:
wm8993->mclk_rate = freq;
+ /* fall through */
case WM8993_SYSCLK_FLL:
wm8993->sysclk_source = clk_id;
break;
@@ -1123,6 +1124,7 @@ static int wm8993_set_dai_fmt(struct snd_soc_dai *dai,
switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
case SND_SOC_DAIFMT_DSP_B:
aif1 |= WM8993_AIF_LRCLK_INV;
+ /* fall through */
case SND_SOC_DAIFMT_DSP_A:
aif1 |= 0x18;
break;
--
2.7.4
From 1584960659087189672@xxx Fri Nov 24 15:11:13 +0000 2017
X-GM-THRID: 1584960659087189672
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 146566
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
sound/soc/codecs/tlv320aic23.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c
index 3d42138..7490921 100644
--- a/sound/soc/codecs/tlv320aic23.c
+++ b/sound/soc/codecs/tlv320aic23.c
@@ -454,6 +454,7 @@ static int tlv320aic23_set_dai_fmt(struct snd_soc_dai *codec_dai,
break;
case SND_SOC_DAIFMT_DSP_A:
iface_reg |= TLV320AIC23_LRP_ON;
+ /* fall through */
case SND_SOC_DAIFMT_DSP_B:
iface_reg |= TLV320AIC23_FOR_DSP;
break;
--
2.7.4
From 1583533484792807917@xxx Wed Nov 08 21:06:53 +0000 2017
X-GM-THRID: 1583533484792807917
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1397957
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
sound/soc/codecs/msm8916-wcd-analog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
index 7ff42ef..5f3c42c 100644
--- a/sound/soc/codecs/msm8916-wcd-analog.c
+++ b/sound/soc/codecs/msm8916-wcd-analog.c
@@ -621,6 +621,7 @@ static int pm8916_wcd_analog_enable_adc(struct snd_soc_dapm_widget *w,
case CDC_A_TX_2_EN:
snd_soc_update_bits(codec, CDC_A_MICB_1_CTL,
MICB_1_CTL_CFILT_REF_SEL_MASK, 0);
+ /* fall through */
case CDC_A_TX_3_EN:
snd_soc_update_bits(codec, CDC_D_CDC_CONN_TX2_CTL,
CONN_TX2_SERIAL_TX2_MUX,
--
2.7.4
From 1583467616865694764@xxx Wed Nov 08 03:39:57 +0000 2017
X-GM-THRID: 1583467616865694764
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1195220
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
sound/soc/codecs/tlv320aic31xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c
index 54a87a9..e286237 100644
--- a/sound/soc/codecs/tlv320aic31xx.c
+++ b/sound/soc/codecs/tlv320aic31xx.c
@@ -929,7 +929,7 @@ static int aic31xx_set_dai_fmt(struct snd_soc_dai *codec_dai,
case SND_SOC_DAIFMT_I2S:
break;
case SND_SOC_DAIFMT_DSP_A:
- dsp_a_val = 0x1;
+ dsp_a_val = 0x1; /* fall through */
case SND_SOC_DAIFMT_DSP_B:
/* NOTE: BCLKINV bit value 1 equas NB and 0 equals IB */
switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
--
2.7.4
From 1583534553670434832@xxx Wed Nov 08 21:23:52 +0000 2017
X-GM-THRID: 1583534070742952709
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread