2020-07-07 19:50:56

by Alexander A. Klimov

[permalink] [raw]
Subject: [PATCH] Replace HTTP links with HTTPS ones: kprobes

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <[email protected]>
---
Continuing my work started at 93431e0607e5.

If there are any URLs to be removed completely or at least not HTTPSified:
Just clearly say so and I'll *undo my change*.
See also https://lkml.org/lkml/2020/6/27/64

If there are any valid, but yet not changed URLs:
See https://lkml.org/lkml/2020/6/26/837

Documentation/kprobes.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt
index 8baab8832c5b..f6990f64154f 100644
--- a/Documentation/kprobes.txt
+++ b/Documentation/kprobes.txt
@@ -693,7 +693,7 @@ process. Here are sample overhead figures (in usec) for x86 architectures::
TODO
====

-a. SystemTap (http://sourceware.org/systemtap): Provides a simplified
+a. SystemTap (https://sourceware.org/systemtap): Provides a simplified
programming interface for probe-based instrumentation. Try it out.
b. Kernel return probes for sparc64.
c. Support for other architectures.
@@ -712,8 +712,8 @@ See samples/kprobes/kretprobe_example.c

For additional information on Kprobes, refer to the following URLs:

-- http://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe
-- http://www.redhat.com/magazine/005mar05/features/kprobes/
+- https://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe
+- https://www.redhat.com/magazine/005mar05/features/kprobes/
- http://www-users.cs.umn.edu/~boutcher/kprobes/
- http://www.linuxsymposium.org/2006/linuxsymposium_procv2.pdf (pages 101-115)

--
2.27.0


2020-07-08 09:43:18

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: kprobes

On Tue, 7 Jul 2020 21:49:59 +0200
"Alexander A. Klimov" <[email protected]> wrote:

> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.

OK, but it seems that some of them are disappeared :(

http://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe

-> https://www.ibm.com/developerworks/library/l-kprobes/index.html

http://www.redhat.com/magazine/005mar05/features/kprobes/

-> I can not find that.

> - http://www-users.cs.umn.edu/~boutcher/kprobes/
> - http://www.linuxsymposium.org/2006/linuxsymposium_procv2.pdf (pages 101-115)

Both are not found.

(OT, it seems http://www.linuxsymposium.org/ has been left from historical
Linux Symposium, we must remove it asap)

Thank you,

>
> Signed-off-by: Alexander A. Klimov <[email protected]>
> ---
> Continuing my work started at 93431e0607e5.
>
> If there are any URLs to be removed completely or at least not HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See https://lkml.org/lkml/2020/6/26/837
>
> Documentation/kprobes.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt
> index 8baab8832c5b..f6990f64154f 100644
> --- a/Documentation/kprobes.txt
> +++ b/Documentation/kprobes.txt
> @@ -693,7 +693,7 @@ process. Here are sample overhead figures (in usec) for x86 architectures::
> TODO
> ====
>
> -a. SystemTap (http://sourceware.org/systemtap): Provides a simplified
> +a. SystemTap (https://sourceware.org/systemtap): Provides a simplified
> programming interface for probe-based instrumentation. Try it out.
> b. Kernel return probes for sparc64.
> c. Support for other architectures.
> @@ -712,8 +712,8 @@ See samples/kprobes/kretprobe_example.c
>
> For additional information on Kprobes, refer to the following URLs:
>
> -- http://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe
> -- http://www.redhat.com/magazine/005mar05/features/kprobes/
> +- https://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe
> +- https://www.redhat.com/magazine/005mar05/features/kprobes/
> - http://www-users.cs.umn.edu/~boutcher/kprobes/
> - http://www.linuxsymposium.org/2006/linuxsymposium_procv2.pdf (pages 101-115)
>
> --
> 2.27.0
>


--
Masami Hiramatsu <[email protected]>

2020-07-09 19:17:31

by Alexander A. Klimov

[permalink] [raw]
Subject: [PATCH] kprobes: Replace HTTP links with HTTPS ones

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <[email protected]>
---
I'd really would like to get HTTPSifying done before other tasks...

Documentation/kprobes.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt
index 8baab8832c5b..88b4d2845b37 100644
--- a/Documentation/kprobes.txt
+++ b/Documentation/kprobes.txt
@@ -693,7 +693,7 @@ process. Here are sample overhead figures (in usec) for x86 architectures::
TODO
====

-a. SystemTap (http://sourceware.org/systemtap): Provides a simplified
+a. SystemTap (https://sourceware.org/systemtap): Provides a simplified
programming interface for probe-based instrumentation. Try it out.
b. Kernel return probes for sparc64.
c. Support for other architectures.
--
2.27.0

2020-07-10 13:46:46

by Naveen N. Rao

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: kprobes

Masami Hiramatsu wrote:
> On Tue, 7 Jul 2020 21:49:59 +0200
> "Alexander A. Klimov" <[email protected]> wrote:
>
>> Rationale:
>> Reduces attack surface on kernel devs opening the links for MITM
>> as HTTPS traffic is much harder to manipulate.
>>
>> Deterministic algorithm:
>> For each file:
>> If not .svg:
>> For each line:
>> If doesn't contain `\bxmlns\b`:
>> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>> If both the HTTP and HTTPS versions
>> return 200 OK and serve the same content:
>> Replace HTTP with HTTPS.
>
> OK, but it seems that some of them are disappeared :(
>
> http://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe
>
> -> https://www.ibm.com/developerworks/library/l-kprobes/index.html

That looks right.

>
> http://www.redhat.com/magazine/005mar05/features/kprobes/
>
> -> I can not find that.

Ditto, we should drop that.

>
>> - http://www-users.cs.umn.edu/~boutcher/kprobes/
>> - http://www.linuxsymposium.org/2006/linuxsymposium_procv2.pdf (pages 101-115)
>
> Both are not found.

It looks like the first link is gone, but there seems to be a copy in
the web archive:
https://web.archive.org/web/20061106154519/http://www-users.cs.umn.edu/~boutcher/kprobes/

I suppose we can drop that link.

>
> (OT, it seems http://www.linuxsymposium.org/ has been left from historical
> Linux Symposium, we must remove it asap)

Indeed, I think that link pointed to the Kprobes paper:
https://www.kernel.org/doc/ols/2006/ols2006v2-pages-109-124.pdf


- Naveen

2020-07-13 14:23:21

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: kprobes

Hi Naveen and Alexander,

On Fri, 10 Jul 2020 19:14:47 +0530
"Naveen N. Rao" <[email protected]> wrote:

> Masami Hiramatsu wrote:
> > On Tue, 7 Jul 2020 21:49:59 +0200
> > "Alexander A. Klimov" <[email protected]> wrote:
> >
> >> Rationale:
> >> Reduces attack surface on kernel devs opening the links for MITM
> >> as HTTPS traffic is much harder to manipulate.
> >>
> >> Deterministic algorithm:
> >> For each file:
> >> If not .svg:
> >> For each line:
> >> If doesn't contain `\bxmlns\b`:
> >> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> >> If both the HTTP and HTTPS versions
> >> return 200 OK and serve the same content:
> >> Replace HTTP with HTTPS.
> >
> > OK, but it seems that some of them are disappeared :(
> >
> > http://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe
> >
> > -> https://www.ibm.com/developerworks/library/l-kprobes/index.html
>
> That looks right.
>
> >
> > http://www.redhat.com/magazine/005mar05/features/kprobes/
> >
> > -> I can not find that.
>
> Ditto, we should drop that.
>
> >
> >> - http://www-users.cs.umn.edu/~boutcher/kprobes/
> >> - http://www.linuxsymposium.org/2006/linuxsymposium_procv2.pdf (pages 101-115)
> >
> > Both are not found.
>
> It looks like the first link is gone, but there seems to be a copy in
> the web archive:
> https://web.archive.org/web/20061106154519/http://www-users.cs.umn.edu/~boutcher/kprobes/
>
> I suppose we can drop that link.
>
> >
> > (OT, it seems http://www.linuxsymposium.org/ has been left from historical
> > Linux Symposium, we must remove it asap)
>
> Indeed, I think that link pointed to the Kprobes paper:
> https://www.kernel.org/doc/ols/2006/ols2006v2-pages-109-124.pdf

Ah, there is.
Thank you for the confirmation.
Alexander, can you update other urls instead of just replacing the http with https?

>
>
> - Naveen
>


--
Masami Hiramatsu <[email protected]>

2020-07-13 15:41:21

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] kprobes: Replace HTTP links with HTTPS ones

On Thu, 9 Jul 2020 21:16:36 +0200
"Alexander A. Klimov" <[email protected]> wrote:

> Documentation/kprobes.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This file no longer exists in docs-next or linux-next (it's been converted
to RST and moved). What tree are you making your patches against?

jon

2020-07-13 22:00:04

by Alexander A. Klimov

[permalink] [raw]
Subject: Re: [PATCH] kprobes: Replace HTTP links with HTTPS ones



Am 13.07.20 um 17:40 schrieb Jonathan Corbet:
> On Thu, 9 Jul 2020 21:16:36 +0200
> "Alexander A. Klimov" <[email protected]> wrote:
>
>> Documentation/kprobes.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This file no longer exists in docs-next or linux-next (it's been converted
OK, forget this patch.

> to RST and moved). What tree are you making your patches against?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/

>
> jon
>

2020-07-13 22:03:54

by Alexander A. Klimov

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: kprobes



Am 13.07.20 um 16:20 schrieb Masami Hiramatsu:
> Hi Naveen and Alexander,
>
> On Fri, 10 Jul 2020 19:14:47 +0530
> "Naveen N. Rao" <[email protected]> wrote:
>
>> Masami Hiramatsu wrote:
>>> On Tue, 7 Jul 2020 21:49:59 +0200
>>> "Alexander A. Klimov" <[email protected]> wrote:
>>>
>>>> Rationale:
>>>> Reduces attack surface on kernel devs opening the links for MITM
>>>> as HTTPS traffic is much harder to manipulate.
>>>>
>>>> Deterministic algorithm:
>>>> For each file:
>>>> If not .svg:
>>>> For each line:
>>>> If doesn't contain `\bxmlns\b`:
>>>> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>>>> If both the HTTP and HTTPS versions
>>>> return 200 OK and serve the same content:
>>>> Replace HTTP with HTTPS.
>>>
>>> OK, but it seems that some of them are disappeared :(
>>>
>>> http://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe
>>>
>>> -> https://www.ibm.com/developerworks/library/l-kprobes/index.html
>>
>> That looks right.
>>
>>>
>>> http://www.redhat.com/magazine/005mar05/features/kprobes/
>>>
>>> -> I can not find that.
>>
>> Ditto, we should drop that.
>>
>>>
>>>> - http://www-users.cs.umn.edu/~boutcher/kprobes/
>>>> - http://www.linuxsymposium.org/2006/linuxsymposium_procv2.pdf (pages 101-115)
>>>
>>> Both are not found.
>>
>> It looks like the first link is gone, but there seems to be a copy in
>> the web archive:
>> https://web.archive.org/web/20061106154519/http://www-users.cs.umn.edu/~boutcher/kprobes/
>>
>> I suppose we can drop that link.
>>
>>>
>>> (OT, it seems http://www.linuxsymposium.org/ has been left from historical
>>> Linux Symposium, we must remove it asap)
>>
>> Indeed, I think that link pointed to the Kprobes paper:
>> https://www.kernel.org/doc/ols/2006/ols2006v2-pages-109-124.pdf
>
> Ah, there is.
> Thank you for the confirmation.
> Alexander, can you update other urls instead of just replacing the http with https?
Sry, but I don't steal others' work (on principle).

If I didn't the work (e.g. searched the replacement URL), I don't
deserve to author the respective commit.

Also my HTTPSifying task is not done yet.

>
>>
>>
>> - Naveen
>>
>
>

2020-07-20 12:04:36

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: kprobes

On Tue, 14 Jul 2020 00:02:49 +0200
"Alexander A. Klimov" <[email protected]> wrote:

>
>
> Am 13.07.20 um 16:20 schrieb Masami Hiramatsu:
> > Hi Naveen and Alexander,
> >
> > On Fri, 10 Jul 2020 19:14:47 +0530
> > "Naveen N. Rao" <[email protected]> wrote:
> >
> >> Masami Hiramatsu wrote:
> >>> On Tue, 7 Jul 2020 21:49:59 +0200
> >>> "Alexander A. Klimov" <[email protected]> wrote:
> >>>
> >>>> Rationale:
> >>>> Reduces attack surface on kernel devs opening the links for MITM
> >>>> as HTTPS traffic is much harder to manipulate.
> >>>>
> >>>> Deterministic algorithm:
> >>>> For each file:
> >>>> If not .svg:
> >>>> For each line:
> >>>> If doesn't contain `\bxmlns\b`:
> >>>> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> >>>> If both the HTTP and HTTPS versions
> >>>> return 200 OK and serve the same content:
> >>>> Replace HTTP with HTTPS.
> >>>
> >>> OK, but it seems that some of them are disappeared :(
> >>>
> >>> http://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe
> >>>
> >>> -> https://www.ibm.com/developerworks/library/l-kprobes/index.html
> >>
> >> That looks right.
> >>
> >>>
> >>> http://www.redhat.com/magazine/005mar05/features/kprobes/
> >>>
> >>> -> I can not find that.
> >>
> >> Ditto, we should drop that.
> >>
> >>>
> >>>> - http://www-users.cs.umn.edu/~boutcher/kprobes/
> >>>> - http://www.linuxsymposium.org/2006/linuxsymposium_procv2.pdf (pages 101-115)
> >>>
> >>> Both are not found.
> >>
> >> It looks like the first link is gone, but there seems to be a copy in
> >> the web archive:
> >> https://web.archive.org/web/20061106154519/http://www-users.cs.umn.edu/~boutcher/kprobes/
> >>
> >> I suppose we can drop that link.
> >>
> >>>
> >>> (OT, it seems http://www.linuxsymposium.org/ has been left from historical
> >>> Linux Symposium, we must remove it asap)
> >>
> >> Indeed, I think that link pointed to the Kprobes paper:
> >> https://www.kernel.org/doc/ols/2006/ols2006v2-pages-109-124.pdf
> >
> > Ah, there is.
> > Thank you for the confirmation.
> > Alexander, can you update other urls instead of just replacing the http with https?
> Sry, but I don't steal others' work (on principle).
>
> If I didn't the work (e.g. searched the replacement URL), I don't
> deserve to author the respective commit.
>
> Also my HTTPSifying task is not done yet.

Hmm, Naveen, then, can you make the update?

Thank you,

--
Masami Hiramatsu <[email protected]>

2020-07-21 09:32:33

by Naveen N. Rao

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: kprobes

Masami Hiramatsu wrote:
> On Tue, 14 Jul 2020 00:02:49 +0200
> "Alexander A. Klimov" <[email protected]> wrote:
>
>>
>>
>> Am 13.07.20 um 16:20 schrieb Masami Hiramatsu:
>> > Hi Naveen and Alexander,
>> >
>> > On Fri, 10 Jul 2020 19:14:47 +0530
>> > "Naveen N. Rao" <[email protected]> wrote:
>> >
>> >> Masami Hiramatsu wrote:
>> >>> On Tue, 7 Jul 2020 21:49:59 +0200
>> >>> "Alexander A. Klimov" <[email protected]> wrote:
>> >>>
>> >>>> Rationale:
>> >>>> Reduces attack surface on kernel devs opening the links for MITM
>> >>>> as HTTPS traffic is much harder to manipulate.
>> >>>>
>> >>>> Deterministic algorithm:
>> >>>> For each file:
>> >>>> If not .svg:
>> >>>> For each line:
>> >>>> If doesn't contain `\bxmlns\b`:
>> >>>> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>> >>>> If both the HTTP and HTTPS versions
>> >>>> return 200 OK and serve the same content:
>> >>>> Replace HTTP with HTTPS.
>> >>>
>> >>> OK, but it seems that some of them are disappeared :(
>> >>>
>> >>> http://www-106.ibm.com/developerworks/library/l-kprobes.html?ca=dgr-lnxw42Kprobe
>> >>>
>> >>> -> https://www.ibm.com/developerworks/library/l-kprobes/index.html
>> >>
>> >> That looks right.
>> >>
>> >>>
>> >>> http://www.redhat.com/magazine/005mar05/features/kprobes/
>> >>>
>> >>> -> I can not find that.
>> >>
>> >> Ditto, we should drop that.
>> >>
>> >>>
>> >>>> - http://www-users.cs.umn.edu/~boutcher/kprobes/
>> >>>> - http://www.linuxsymposium.org/2006/linuxsymposium_procv2.pdf (pages 101-115)
>> >>>
>> >>> Both are not found.
>> >>
>> >> It looks like the first link is gone, but there seems to be a copy in
>> >> the web archive:
>> >> https://web.archive.org/web/20061106154519/http://www-users.cs.umn.edu/~boutcher/kprobes/
>> >>
>> >> I suppose we can drop that link.
>> >>
>> >>>
>> >>> (OT, it seems http://www.linuxsymposium.org/ has been left from historical
>> >>> Linux Symposium, we must remove it asap)
>> >>
>> >> Indeed, I think that link pointed to the Kprobes paper:
>> >> https://www.kernel.org/doc/ols/2006/ols2006v2-pages-109-124.pdf
>> >
>> > Ah, there is.
>> > Thank you for the confirmation.
>> > Alexander, can you update other urls instead of just replacing the http with https?
>> Sry, but I don't steal others' work (on principle).
>>
>> If I didn't the work (e.g. searched the replacement URL), I don't
>> deserve to author the respective commit.

Alexander,
Next time, please ask if you aren't sure about including others'
suggestions -- no need to term it as "stealing". Masami asked if you can
include this, and I shared what I thought are the correct URLs so that
they can be included. We don't mind someone else doing this change.

Besides, there are ways to acknowledge others, through a Suggested-by
tag, as an example.

>>
>> Also my HTTPSifying task is not done yet.
>
> Hmm, Naveen, then, can you make the update?

Sure, I will send a patch.


- Naveen

2020-07-21 13:34:05

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH] kprobes: Replace HTTP links with HTTPS ones

On Thu, 9 Jul 2020 21:16:36 +0200
"Alexander A. Klimov" <[email protected]> wrote:

> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>

Acked-by: Masami Hiramatsu <[email protected]>

Thanks!

> Signed-off-by: Alexander A. Klimov <[email protected]>
> ---
> I'd really would like to get HTTPSifying done before other tasks...
>
> Documentation/kprobes.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt
> index 8baab8832c5b..88b4d2845b37 100644
> --- a/Documentation/kprobes.txt
> +++ b/Documentation/kprobes.txt
> @@ -693,7 +693,7 @@ process. Here are sample overhead figures (in usec) for x86 architectures::
> TODO
> ====
>
> -a. SystemTap (http://sourceware.org/systemtap): Provides a simplified
> +a. SystemTap (https://sourceware.org/systemtap): Provides a simplified
> programming interface for probe-based instrumentation. Try it out.
> b. Kernel return probes for sparc64.
> c. Support for other architectures.
> --
> 2.27.0
>


--
Masami Hiramatsu <[email protected]>