Add documentation to describe Sunplus SP7021 interrupt controller bindings.
Signed-off-by: Qin Jian <[email protected]>
---
Move 'reg' after 'compatible'
---
.../sunplus,sp7021-intc.yaml | 62 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 63 insertions(+)
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
diff --git a/Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
new file mode 100644
index 000000000..f26d8b213
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) Sunplus Co., Ltd. 2021
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/sunplus,sp7021-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sunplus SP7021 SoC Interrupt Controller Device Tree Bindings
+
+maintainers:
+ - Qin Jian <[email protected]>
+
+properties:
+ compatible:
+ items:
+ - const: sunplus,sp7021-intc
+
+ reg:
+ maxItems: 2
+ description:
+ Specifies base physical address(s) and size of the controller regs.
+ The 1st region include type/polarity/priority/mask regs.
+ The 2nd region include clear/masked_ext0/masked_ext1/group regs.
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+ description:
+ The first cell is the IRQ number, the second cell is the trigger
+ type as defined in interrupt.txt in this directory.
+
+ interrupts:
+ maxItems: 2
+ description:
+ EXT_INT0 & EXT_INT1, 2 interrupts references to primary interrupt
+ controller.
+
+required:
+ - compatible
+ - reg
+ - interrupt-controller
+ - "#interrupt-cells"
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ intc: interrupt-controller@9c000780 {
+ compatible = "sunplus,sp7021-intc";
+ reg = <0x9c000780 0x80>, <0x9c000a80 0x80>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>, /* EXT_INT0 */
+ <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; /* EXT_INT1 */
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 8b77f7ae4..9fba67159 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2745,6 +2745,7 @@ S: Maintained
W: https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview
F: Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml
F: Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
+F: Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
F: Documentation/devicetree/bindings/reset/sunplus,reset.yaml
F: drivers/clk/clk-sp7021.c
F: drivers/reset/reset-sunplus.c
--
2.33.1
On Thu, 31 Mar 2022 16:29:53 +0800, Qin Jian wrote:
> Add documentation to describe Sunplus SP7021 interrupt controller bindings.
>
> Signed-off-by: Qin Jian <[email protected]>
> ---
> Move 'reg' after 'compatible'
> ---
> .../sunplus,sp7021-intc.yaml | 62 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
>
> On Thu, 31 Mar 2022 16:29:53 +0800, Qin Jian wrote:
> > Add documentation to describe Sunplus SP7021 interrupt controller bindings.
> >
> > Signed-off-by: Qin Jian <[email protected]>
> > ---
> > Move 'reg' after 'compatible'
> > ---
> > .../sunplus,sp7021-intc.yaml | 62 +++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 63 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
> >
>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
Changes: Move 'reg' after 'compatible'
I did a modification based on comments from [email protected] [1]
[1] https://lore.kernel.org/all/[email protected]/
On Fri, Apr 01, 2022 at 02:29:58AM +0000, qinjian[覃健] wrote:
> >
> > On Thu, 31 Mar 2022 16:29:53 +0800, Qin Jian wrote:
> > > Add documentation to describe Sunplus SP7021 interrupt controller bindings.
> > >
> > > Signed-off-by: Qin Jian <[email protected]>
> > > ---
> > > Move 'reg' after 'compatible'
> > > ---
> > > .../sunplus,sp7021-intc.yaml | 62 +++++++++++++++++++
> > > MAINTAINERS | 1 +
> > > 2 files changed, 63 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
> > >
> >
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> Changes: Move 'reg' after 'compatible'
> I did a modification based on comments from [email protected] [1]
>
> [1] https://lore.kernel.org/all/[email protected]/
A trivial change like that can keep a tag especially if it came after
the comment (not sure here).
Rob
>
> On Fri, Apr 01, 2022 at 02:29:58AM +0000, qinjian[覃健] wrote:
> > >
> > > On Thu, 31 Mar 2022 16:29:53 +0800, Qin Jian wrote:
> > > > Add documentation to describe Sunplus SP7021 interrupt controller bindings.
> > > >
> > > > Signed-off-by: Qin Jian <[email protected]>
> > > > ---
> > > > Move 'reg' after 'compatible'
> > > > ---
> > > > .../sunplus,sp7021-intc.yaml | 62 +++++++++++++++++++
> > > > MAINTAINERS | 1 +
> > > > 2 files changed, 63 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
> > > >
> > >
> > >
> > > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > > there's no need to repost patches *only* to add the tags. The upstream
> > > maintainer will do that for acks received on the version they apply.
> > >
> > > If a tag was not added on purpose, please state why and what changed.
> >
> > Changes: Move 'reg' after 'compatible'
> > I did a modification based on comments from [email protected] [1]
> >
> > [1] https://lore.kernel.org/all/[email protected]/
>
> A trivial change like that can keep a tag especially if it came after
> the comment (not sure here).
>
> Rob
I'll add back the tag next version, thanks.