2020-11-16 03:07:59

by Xiongfeng Wang

Subject: [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()

Fix to return a negative error code from the error handling case instead
of 0 in function sun8i_dw_hdmi_bind().

Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Xiongfeng Wang <[email protected]>
Reviewed-by: Jernej Skrabec <[email protected]>
---
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
index d4c0804..92add2c 100644
--- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
+++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
@@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master,
phy_node = of_parse_phandle(dev->of_node, "phys", 0);
if (!phy_node) {
dev_err(dev, "Can't found PHY phandle\n");
+ ret = -EINVAL;
goto err_disable_clk_tmds;
}

--
1.7.12.4

2020-11-17 17:43:54

by Jernej Skrabec

Subject: Re: [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()

Dne ponedeljek, 16. november 2020 ob 02:09:29 CET je Xiongfeng Wang
napisal(a):
> Fix to return a negative error code from the error handling case instead
> of 0 in function sun8i_dw_hdmi_bind().
>
> Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Xiongfeng Wang <[email protected]>
> Reviewed-by: Jernej Skrabec <[email protected]>

Applied to drm-misc-fixes, thanks!

In future, please CC all people given by get_maintainer.pl script. In this
case you missed Maxime Ripard and Chen-Yu Tsai.

Best regards,
Jernej

2020-11-18 01:06:42

by Xiongfeng Wang

Subject: Re: [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()

On 2020/11/18 1:47, Jernej Škrabec wrote:
> Dne ponedeljek, 16. november 2020 ob 02:09:29 CET je Xiongfeng Wang
> napisal(a):
>> Fix to return a negative error code from the error handling case instead
>> of 0 in function sun8i_dw_hdmi_bind().
>>
>> Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Xiongfeng Wang <[email protected]>
>> Reviewed-by: Jernej Skrabec <[email protected]>
>
> Applied to drm-misc-fixes, thanks!
>
> In future, please CC all people given by get_maintainer.pl script. In this
> case you missed Maxime Ripard and Chen-Yu Tsai.

Sure, thanks for reminding me.

Thanks,
Xiongfeng

>
> Best regards,
> Jernej
>
>
> .
>