2022-06-20 17:53:23

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 0/3] leds/arm: dts: leds on Samsung Galaxy S3

Hi,

Merging
=======
1. Bindings patch: via leds tree.
2. DTS patches: I will take them via Samsung SoC tree.

Changes since v1
================
1. Drop the label from example and DTS, per discussions with Jacek.

Best regards,
Krzysztof

Krzysztof Kozlowski (3):
dt-bindings: leds: skyworks,aat1290: convert to dtschema
ARM: dts: exynos: align aat1290 flash LED node with bindings in Galaxy
S3
ARM: dts: exynos: add function and color to aat1290 flash LED node in
Galaxy S3

.../devicetree/bindings/leds/leds-aat1290.txt | 77 ---------------
.../bindings/leds/skyworks,aat1290.yaml | 95 +++++++++++++++++++
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 6 +-
3 files changed, 99 insertions(+), 79 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/leds/leds-aat1290.txt
create mode 100644 Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml

--
2.34.1


2022-06-20 17:56:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 3/3] ARM: dts: exynos: add function and color to aat1290 flash LED node in Galaxy S3

Add common LED properties - the function and color - to aat1290 flash
LED node in Galaxy S3, so we can drop deprecated label property.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
index 46640b490a8c..94122e9c6625 100644
--- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
+++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
@@ -7,6 +7,7 @@
*/

/dts-v1/;
+#include <dt-bindings/leds/common.h>
#include "exynos4412-midas.dtsi"

/ {
@@ -26,7 +27,8 @@ led-controller {
pinctrl-2 = <&camera_flash_isp>;

led {
- label = "flash";
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
led-max-microamp = <520833>;
flash-max-microamp = <1012500>;
flash-max-timeout-us = <1940000>;
--
2.34.1

2022-06-20 17:56:27

by Jacek Anaszewski

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] leds/arm: dts: leds on Samsung Galaxy S3

Hi Krzysztof,

On 6/20/22 19:50, Krzysztof Kozlowski wrote:
> Hi,
>
> Merging
> =======
> 1. Bindings patch: via leds tree.
> 2. DTS patches: I will take them via Samsung SoC tree.
>
> Changes since v1
> ================
> 1. Drop the label from example and DTS, per discussions with Jacek.
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (3):
> dt-bindings: leds: skyworks,aat1290: convert to dtschema
> ARM: dts: exynos: align aat1290 flash LED node with bindings in Galaxy
> S3
> ARM: dts: exynos: add function and color to aat1290 flash LED node in
> Galaxy S3
>
> .../devicetree/bindings/leds/leds-aat1290.txt | 77 ---------------
> .../bindings/leds/skyworks,aat1290.yaml | 95 +++++++++++++++++++
> arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 6 +-
> 3 files changed, 99 insertions(+), 79 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/leds/leds-aat1290.txt
> create mode 100644 Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
>

For the whole set:

Acked-by: Jacek Anaszewski <[email protected]>

--
Best regards,
Jacek Anaszewski

2022-06-22 12:17:30

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: (subset) [PATCH v2 3/3] ARM: dts: exynos: add function and color to aat1290 flash LED node in Galaxy S3

On Mon, 20 Jun 2022 19:50:33 +0200, Krzysztof Kozlowski wrote:
> Add common LED properties - the function and color - to aat1290 flash
> LED node in Galaxy S3, so we can drop deprecated label property.
>
>

Applied, thanks!

[3/3] ARM: dts: exynos: add function and color to aat1290 flash LED node in Galaxy S3
https://git.kernel.org/krzk/linux/c/ebadc8a63645f7923dc63154ad8d290313f03101

Best regards,
--
Krzysztof Kozlowski <[email protected]>