2024-01-22 07:11:38

by Raag Jadav

Subject: [PATCH v1 2/2] i2c: designware: constify regmap_config

We never modify regmap_config, mark it as const.

Signed-off-by: Raag Jadav <[email protected]>
---
drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 855b698e99c0..d122ef349b1c 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -100,7 +100,7 @@ static int bt1_i2c_write(void *context, unsigned int reg, unsigned int val)
BT1_I2C_CTL_GO | BT1_I2C_CTL_WR | (reg & BT1_I2C_CTL_ADDR_MASK));
}

-static struct regmap_config bt1_i2c_cfg = {
+static const struct regmap_config bt1_i2c_cfg = {
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.35.3

2024-01-22 15:19:22

by Jarkko Nikula

Subject: Re: [PATCH v1 2/2] i2c: designware: constify regmap_config

On 1/22/24 05:31, Raag Jadav wrote:
> We never modify regmap_config, mark it as const.
>
> Signed-off-by: Raag Jadav <[email protected]>
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Both:

Acked-by: Jarkko Nikula <[email protected]>

2024-02-08 10:46:22

by Raag Jadav

Subject: Re: [PATCH v1 2/2] i2c: designware: constify regmap_config

On Mon, Jan 22, 2024 at 11:44:22AM +0200, Jarkko Nikula wrote:
> On 1/22/24 05:31, Raag Jadav wrote:
> > We never modify regmap_config, mark it as const.
> >
> > Signed-off-by: Raag Jadav <[email protected]>
> > ---
> > drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> Both:
>
> Acked-by: Jarkko Nikula <[email protected]>

Bump.

Anything I can do to move these forward?

Raag

2024-03-04 07:58:50

by Raag Jadav

Subject: Re: [PATCH v1 2/2] i2c: designware: constify regmap_config

On Thu, Feb 08, 2024 at 12:46:07PM +0200, Raag Jadav wrote:
> On Mon, Jan 22, 2024 at 11:44:22AM +0200, Jarkko Nikula wrote:
> > On 1/22/24 05:31, Raag Jadav wrote:
> > > We never modify regmap_config, mark it as const.
> > >
> > > Signed-off-by: Raag Jadav <[email protected]>
> > > ---
> > > drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Both:
> >
> > Acked-by: Jarkko Nikula <[email protected]>
>
> Bump.
>
> Anything I can do to move these forward?

Hi Andi,

Are these worth moving forward?

Raag