2020-10-01 18:53:19

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH v1] PCI: brcmstb: fix error return paths in probe()



On 10/1/2020 8:18 AM, Jim Quinlan wrote:
> Fixes two cases where we were returning without calling
> clk_disable_unprepare(). Although there is a common place to go on probe()
> errors (the 'fail' label), one can only jump there after executing
> brcm_pcie_setup(), so we have to add clk_disable_unprepare() calls to the
> two error paths.
>
> Fixes: b98f52bc6495 ("PCI: brcmstb: Add control of rescal reset")
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Jim Quinlan <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-10-08 10:00:40

by Nicolas Saenz Julienne

[permalink] [raw]
Subject: Re: [PATCH v1] PCI: brcmstb: fix error return paths in probe()

On Thu, 2020-10-01 at 11:18 -0400, Jim Quinlan wrote:
> Fixes two cases where we were returning without calling
> clk_disable_unprepare(). Although there is a common place to go on probe()
> errors (the 'fail' label), one can only jump there after executing
> brcm_pcie_setup(), so we have to add clk_disable_unprepare() calls to the
> two error paths.
>
> Fixes: b98f52bc6495 ("PCI: brcmstb: Add control of rescal reset")
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Jim Quinlan <[email protected]>
> ---

Reviewed-by: Nicolas Saenz Julienne <[email protected]>

Thanks!