2023-09-25 08:45:50

by Kumar, Udit

[permalink] [raw]
Subject: Re: [PATCH v3 2/7] arm64: dts: ti: k3-j784s4: Add ESM instances


On 9/11/2023 9:39 AM, Keerthy wrote:
> Patch adds the ESM instances for j784s4. It has 3 instances.
> One in the main domain and two in the mcu-wakeup domian.
>
> Signed-off-by: Keerthy <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 7 +++++++
> arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 12 ++++++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index efed2d683f63..02d549a2ca06 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -1568,4 +1568,11 @@
> firmware-name = "j784s4-c71_3-fw";
> status = "disabled";
> };
> +
> + main_esm: esm@700000 {
> + compatible = "ti,j721e-esm";
> + reg = <0x00 0x700000 0x00 0x1000>;
> + ti,esm-pins = <688>, <689>, <690>, <691>, <692>, <693>, <694>,
> + <695>;
> + };
> };
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> index 4ab4018d3695..f1dfa4144168 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> @@ -700,4 +700,16 @@
> status = "disabled";
> };
> };
> +
> + mcu_esm: esm@40800000 {
> + compatible = "ti,j721e-esm";
> + reg = <0x00 0x40800000 0x00 0x1000>;
> + ti,esm-pins = <95>;
> + };
> +
> + wkup_esm: esm@42080000 {
> + compatible = "ti,j721e-esm";
> + reg = <0x00 0x42080000 0x00 0x1000>;
> + ti,esm-pins = <63>;
> + };


Please consider adding bootph node for esm,

I understand these nodes will be used in R5/SPL

Thanks

> };