2005/11/1, [email protected] <[email protected]>:
>
> The patch titled
>
> swap-migration-v5-lru-operations-tweaks
>
> has been added to the -mm tree. Its filename is
>
> swap-migration-v5-lru-operations-tweaks.patch
>
>
> From: Andrew Morton <[email protected]>
>
> Cc: Christoph Lameter <[email protected]>
> Signed-off-by: Andrew Morton <[email protected]>
> ---
>
> include/linux/mm_inline.h | 4 +---
> mm/vmscan.c | 6 +++---
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff -puN include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaks include/linux/mm_inline.h
> --- devel/include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaks 2005-10-31 21:21:48.000000000 -0800
> +++ devel-akpm/include/linux/mm_inline.h 2005-10-31 21:21:48.000000000 -0800
> @@ -44,8 +44,7 @@ del_page_from_lru(struct zone *zone, str
> *
> * - zone->lru_lock must be held
> */
> -static inline int
> -__isolate_lru_page(struct zone *zone, struct page *page)
> +static inline int __isolate_lru_page(struct zone *zone, struct page *page)
> {
> if (TestClearPageLRU(page)) {
> if (get_page_testone(page)) {
My curiosity, why we do this when the former is friendly to grep? Any
coding style document about this?
--
Coywolf Qi Hunt
http://sosdg.org/~coywolf/
Coywolf Qi Hunt <[email protected]> wrote:
>
> 2005/11/1, [email protected] <[email protected]>:
> >
> > The patch titled
> >
> > swap-migration-v5-lru-operations-tweaks
> >
> > has been added to the -mm tree. Its filename is
> >
> > swap-migration-v5-lru-operations-tweaks.patch
> >
> >
> > From: Andrew Morton <[email protected]>
> >
> > Cc: Christoph Lameter <[email protected]>
> > Signed-off-by: Andrew Morton <[email protected]>
> > ---
> >
> > include/linux/mm_inline.h | 4 +---
> > mm/vmscan.c | 6 +++---
> > 2 files changed, 4 insertions(+), 6 deletions(-)
> >
> > diff -puN include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaks include/linux/mm_inline.h
> > --- devel/include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaks 2005-10-31 21:21:48.000000000 -0800
> > +++ devel-akpm/include/linux/mm_inline.h 2005-10-31 21:21:48.000000000 -0800
> > @@ -44,8 +44,7 @@ del_page_from_lru(struct zone *zone, str
> > *
> > * - zone->lru_lock must be held
> > */
> > -static inline int
> > -__isolate_lru_page(struct zone *zone, struct page *page)
> > +static inline int __isolate_lru_page(struct zone *zone, struct page *page)
> > {
> > if (TestClearPageLRU(page)) {
> > if (get_page_testone(page)) {
>
> My curiosity, why we do this when the former is friendly to grep?
It's easier to read.
> Any coding style document about this?
Dunno. I have a rude email from Linus here somewhere from when I used to
do it that way ;)