2006-01-03 21:31:10

by Ed L. Cashin

Subject: [PATCH 2.6.15-rc7] aoe [4/7]: use less confusing driver name

Signed-off-by: "Ed L. Cashin" <[email protected]>

Users were confused by the driver being called "aoe-2.6-$version".
This form looks less like a Linux kernel version number.

Index: 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c
===================================================================
--- 2.6.15-rc7-aoe.orig/drivers/block/aoe/aoemain.c 2006-01-02 13:35:13.000000000 -0500
+++ 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c 2006-01-02 13:35:14.000000000 -0500
@@ -89,7 +89,7 @@
}

printk(KERN_INFO
- "aoe: aoe_init: AoE v2.6-%s initialised.\n",
+ "aoe: aoe_init: aoe6-%s initialised.\n",
VERSION);
discover_timer(TINIT);
return 0;


--
Ed L. Cashin <[email protected]>

2006-01-04 06:02:20

by Coywolf Qi Hunt

Subject: Re: [PATCH 2.6.15-rc7] aoe [4/7]: use less confusing driver name

2006/1/4, Ed L. Cashin <[email protected]>:
> Signed-off-by: "Ed L. Cashin" <[email protected]>
>
> Users were confused by the driver being called "aoe-2.6-$version".
> This form looks less like a Linux kernel version number.
>
> Index: 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c
> ===================================================================
> --- 2.6.15-rc7-aoe.orig/drivers/block/aoe/aoemain.c 2006-01-02 13:35:13.000000000 -0500
> +++ 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c 2006-01-02 13:35:14.000000000 -0500
> @@ -89,7 +89,7 @@
> }
>
> printk(KERN_INFO
> - "aoe: aoe_init: AoE v2.6-%s initialised.\n",
> + "aoe: aoe_init: aoe6-%s initialised.\n",
> VERSION);

Better simply be `AoE v%s'?

> discover_timer(TINIT);
> return 0;
>
>
--
Coywolf Qi Hunt

2006-01-04 17:23:56

by Ed L. Cashin

Subject: Re: [PATCH 2.6.15-rc7] aoe [4/7]: use less confusing driver name

Coywolf Qi Hunt <[email protected]> writes:

> 2006/1/4, Ed L. Cashin <[email protected]>:
>> Signed-off-by: "Ed L. Cashin" <[email protected]>
>>
>> Users were confused by the driver being called "aoe-2.6-$version".
>> This form looks less like a Linux kernel version number.
>>
>> Index: 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c
>> ===================================================================
>> --- 2.6.15-rc7-aoe.orig/drivers/block/aoe/aoemain.c 2006-01-02 13:35:13.000000000 -0500
>> +++ 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c 2006-01-02 13:35:14.000000000 -0500
>> @@ -89,7 +89,7 @@
>> }
>>
>> printk(KERN_INFO
>> - "aoe: aoe_init: AoE v2.6-%s initialised.\n",
>> + "aoe: aoe_init: aoe6-%s initialised.\n",
>> VERSION);
>
> Better simply be `AoE v%s'?

That would be nice, but there's a driver for the 2.4 linux kernel that
has an independent version number, so the "6" distinguishes the 2.6
aoe driver from the 2.4 aoe driver.

--
Ed L Cashin <[email protected]>

2006-01-05 00:52:18

by Coywolf Qi Hunt

Subject: Re: [PATCH 2.6.15-rc7] aoe [4/7]: use less confusing driver name

2006/1/5, Ed L Cashin <[email protected]>:
> Coywolf Qi Hunt <[email protected]> writes:
>
> > 2006/1/4, Ed L. Cashin <[email protected]>:
> >> Signed-off-by: "Ed L. Cashin" <[email protected]>
> >>
> >> Users were confused by the driver being called "aoe-2.6-$version".
> >> This form looks less like a Linux kernel version number.
> >>
> >> Index: 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c
> >> ===================================================================
> >> --- 2.6.15-rc7-aoe.orig/drivers/block/aoe/aoemain.c 2006-01-02 13:35:13.000000000 -0500
> >> +++ 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c 2006-01-02 13:35:14.000000000 -0500
> >> @@ -89,7 +89,7 @@
> >> }
> >>
> >> printk(KERN_INFO
> >> - "aoe: aoe_init: AoE v2.6-%s initialised.\n",
> >> + "aoe: aoe_init: aoe6-%s initialised.\n",
> >> VERSION);
> >
> > Better simply be `AoE v%s'?
>
> That would be nice, but there's a driver for the 2.4 linux kernel that
> has an independent version number, so the "6" distinguishes the 2.6
> aoe driver from the 2.4 aoe driver.

But 2.4 and 2.6 driver never meet each other, right?

>
> --
> Ed L Cashin <[email protected]>
>
>

--
Coywolf Qi Hunt

2006-01-05 16:35:50

by Ed L. Cashin

Subject: Re: [PATCH 2.6.15-rc7] aoe [4/7]: use less confusing driver name

Coywolf Qi Hunt <[email protected]> writes:

[Ed writes]
...
>> Coywolf Qi Hunt <[email protected]> writes:
...
>> > Better simply be `AoE v%s'?
>>
>> That would be nice, but there's a driver for the 2.4 linux kernel that
>> has an independent version number, so the "6" distinguishes the 2.6
>> aoe driver from the 2.4 aoe driver.
>
> But 2.4 and 2.6 driver never meet each other, right?

Yes, after thinking it over more, I agree. Here's a new version of
this patch.


Signed-off-by: "Ed L. Cashin" <[email protected]>

Users were confused by the driver being called "aoe-2.6-$version".
This form looks less like a Linux kernel version number.

Index: 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c
===================================================================
--- 2.6.15-rc7-aoe.orig/drivers/block/aoe/aoemain.c 2006-01-05 11:30:14.000000000 -0500
+++ 2.6.15-rc7-aoe/drivers/block/aoe/aoemain.c 2006-01-05 11:30:15.000000000 -0500
@@ -89,7 +89,7 @@
}

printk(KERN_INFO
- "aoe: aoe_init: AoE v2.6-%s initialised.\n",
+ "aoe: aoe_init: AoE v%s initialised.\n",
VERSION);
discover_timer(TINIT);
return 0;




--
Ed L Cashin <[email protected]>