2024-01-23 15:35:24

by Tudor Ambarus

Subject: [PATCH 04/21] spi: s3c64xx: remove unneeded (void *) casts in of_match_table

of_device_id::data is an opaque pointer. No explicit cast is needed.
Remove unneeded (void *) casts in of_match_table. While here align the
compatible and data members.

Signed-off-by: Tudor Ambarus <[email protected]>
---
drivers/spi/spi-s3c64xx.c | 40 +++++++++++++++++++++++----------------
1 file changed, 24 insertions(+), 16 deletions(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 26d389d95af9..b350e70fd179 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1495,29 +1495,37 @@ static const struct platform_device_id s3c64xx_spi_driver_ids[] = {
};

static const struct of_device_id s3c64xx_spi_dt_match[] = {
- { .compatible = "samsung,s3c2443-spi",
- .data = (void *)&s3c2443_spi_port_config,
+ {
+ .compatible = "samsung,s3c2443-spi",
+ .data = &s3c2443_spi_port_config,
},
- { .compatible = "samsung,s3c6410-spi",
- .data = (void *)&s3c6410_spi_port_config,
+ {
+ .compatible = "samsung,s3c6410-spi",
+ .data = &s3c6410_spi_port_config,
},
- { .compatible = "samsung,s5pv210-spi",
- .data = (void *)&s5pv210_spi_port_config,
+ {
+ .compatible = "samsung,s5pv210-spi",
+ .data = &s5pv210_spi_port_config,
},
- { .compatible = "samsung,exynos4210-spi",
- .data = (void *)&exynos4_spi_port_config,
+ {
+ .compatible = "samsung,exynos4210-spi",
+ .data = &exynos4_spi_port_config,
},
- { .compatible = "samsung,exynos7-spi",
- .data = (void *)&exynos7_spi_port_config,
+ {
+ .compatible = "samsung,exynos7-spi",
+ .data = &exynos7_spi_port_config,
},
- { .compatible = "samsung,exynos5433-spi",
- .data = (void *)&exynos5433_spi_port_config,
+ {
+ .compatible = "samsung,exynos5433-spi",
+ .data = &exynos5433_spi_port_config,
},
- { .compatible = "samsung,exynosautov9-spi",
- .data = (void *)&exynosautov9_spi_port_config,
+ {
+ .compatible = "samsung,exynosautov9-spi",
+ .data = &exynosautov9_spi_port_config,
},
- { .compatible = "tesla,fsd-spi",
- .data = (void *)&fsd_spi_port_config,
+ {
+ .compatible = "tesla,fsd-spi",
+ .data = &fsd_spi_port_config,
},
{ },
};
--
2.43.0.429.g432eaa2c6b-goog

2024-01-23 22:28:49

by Andi Shyti

Subject: Re: [PATCH 04/21] spi: s3c64xx: remove unneeded (void *) casts in of_match_table

Hi Tudor,

On Tue, Jan 23, 2024 at 03:34:03PM +0000, Tudor Ambarus wrote:
> of_device_id::data is an opaque pointer. No explicit cast is needed.
> Remove unneeded (void *) casts in of_match_table. While here align the
> compatible and data members.
>
> Signed-off-by: Tudor Ambarus <[email protected]>

Reviewed-by: Andi Shyti <[email protected]>

Thanks,
Andi