2023-09-28 03:24:43

by KaiLong Wang

[permalink] [raw]

Subject: [PATCH] lib: zstd: Clean up errors in zstd_ddict.h

---

Fix the following errors reported by checkpatch:

ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: KaiLong Wang <[email protected]>
---
lib/zstd/decompress/zstd_ddict.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/zstd/decompress/zstd_ddict.h b/lib/zstd/decompress/zstd_ddict.h
index 8c1a79d666f8..8fd15fca3724 100644
--- a/lib/zstd/decompress/zstd_ddict.h
+++ b/lib/zstd/decompress/zstd_ddict.h
@@ -34,10 +34,10 @@
* ZSTD_getDictID_fromDict()
*/

-const void* ZSTD_DDict_dictContent(const ZSTD_DDict* ddict);
-size_t ZSTD_DDict_dictSize(const ZSTD_DDict* ddict);
+const void *ZSTD_DDict_dictContent(const ZSTD_DDict *ddict);
+size_t ZSTD_DDict_dictSize(const ZSTD_DDict *ddict);

-void ZSTD_copyDDictParameters(ZSTD_DCtx* dctx, const ZSTD_DDict* ddict);
+void ZSTD_copyDDictParameters(ZSTD_DCtx *dctx, const ZSTD_DDict *ddict);



--
2.17.1

2023-10-12 16:18:42

by Nick Terrell

[permalink] [raw]

Subject: Re: [PATCH] lib: zstd: Clean up errors in zstd_ddict.h

---

> On Sep 27, 2023, at 11:23 PM, KaiLong Wang <[email protected]> wrote:
>
> >
> Fix the following errors reported by checkpatch:
>
> ERROR: "foo* bar" should be "foo *bar"

The zstd library is synced from upstream and does not fully conform to the Linux Kernel style guide.

Though if you notice errors in include/linux/zstd.h, our public API, please let me know.

Thanks,
Nick Terrell

> Signed-off-by: KaiLong Wang <[email protected]>
> ---
> lib/zstd/decompress/zstd_ddict.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/zstd/decompress/zstd_ddict.h b/lib/zstd/decompress/zstd_ddict.h
> index 8c1a79d666f8..8fd15fca3724 100644
> --- a/lib/zstd/decompress/zstd_ddict.h
> +++ b/lib/zstd/decompress/zstd_ddict.h
> @@ -34,10 +34,10 @@
> * ZSTD_getDictID_fromDict()
> */
>
> -const void* ZSTD_DDict_dictContent(const ZSTD_DDict* ddict);
> -size_t ZSTD_DDict_dictSize(const ZSTD_DDict* ddict);
> +const void *ZSTD_DDict_dictContent(const ZSTD_DDict *ddict);
> +size_t ZSTD_DDict_dictSize(const ZSTD_DDict *ddict);
>
> -void ZSTD_copyDDictParameters(ZSTD_DCtx* dctx, const ZSTD_DDict* ddict);
> +void ZSTD_copyDDictParameters(ZSTD_DCtx *dctx, const ZSTD_DDict *ddict);
>
>
>
> --
> 2.17.1

---

Attachments:

winmail.dat (13.11 kB)