2022-10-09 12:39:32

by Guido Günther

Subject: [PATCH v1 3/3] arm64: dts: librem5-devkit: Use function and color rather than label

Use predefined colors and function rather than making up a random label.

Signed-off-by: Guido Günther <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 7e4b6d65fd89..4c8904fba1c1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -7,6 +7,7 @@

#include "dt-bindings/input/input.h"
#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/leds/common.h>
#include "dt-bindings/pwm/pwm.h"
#include "dt-bindings/usb/pd.h"
#include "imx8mq.dtsi"
@@ -64,7 +65,8 @@ leds {
compatible = "pwm-leds";

led1 {
- label = "LED 1";
+ function = LED_FUNCTION_STATUS;
+ color = <LED_COLOR_ID_RED>;
max-brightness = <248>;
pwms = <&pwm2 0 50000 0>;
};
--
2.35.1

2022-10-29 01:22:51

by Shawn Guo

Subject: Re: [PATCH v1 3/3] arm64: dts: librem5-devkit: Use function and color rather than label

On Sun, Oct 09, 2022 at 02:26:55PM +0200, Guido G?nther wrote:
> Use predefined colors and function rather than making up a random label.
>
> Signed-off-by: Guido G?nther <[email protected]>

Applied, thanks!