2010-02-10 00:38:16

by Richard Hartmann

[permalink] [raw]
Subject: [PATCH 1/1] SCRIPTS: Fix whitespace in get_maintainer output


Signed-off-by: Richard Hartmann <[email protected]>
---
scripts/get_maintainer.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 2f3230d..430928e 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -278,7 +278,7 @@ foreach my $file (@ARGV) {
}
close(PATCH);
if ($file_cnt == @files) {
- warn "$P: file '${file}' doesn't appear to be a patch. "
+ warn "$P: file '${file}' doesn't appear to be a patch. "
. "Add -f to options?\n";
}
@files = sort_and_uniq(@files);
--
1.6.6.1


2010-02-10 00:47:22

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH 1/1] SCRIPTS: Fix whitespace in get_maintainer output

On Wed, 2010-02-10 at 01:37 +0100, Richard Hartmann wrote:
> - warn "$P: file '${file}' doesn't appear to be a patch. "
> + warn "$P: file '${file}' doesn't appear to be a patch. "

One space not two after periods? Horrors.

Well if you like, but that's not what I like.

Not-acked-by-but-not-specifically-rejected-by etc.

cheers, Joe

FULL STOP

2010-02-10 01:00:56

by Richard Hartmann

[permalink] [raw]
Subject: Re: [PATCH 1/1] SCRIPTS: Fix whitespace in get_maintainer output

On Wed, Feb 10, 2010 at 01:47, Joe Perches <[email protected]> wrote:

> One space not two after periods?  Horrors.

Not quite, but still wrong and worthy of a fix :)

For what it's worth, applying it would take less time than the
sending and reading of these two emails ;)


Still, any feedback is good feedback.

Thanks,
Richard