2024-04-05 09:53:01

by Oleksij Rempel

Subject: [PATCH net-next v3 7/9] net: dsa: microchip: enable ETS support for KSZ989X variants

I tested ETS support on KSZ9893, so it should work other KSZ989X
variants too.

Signed-off-by: Oleksij Rempel <[email protected]>
---
drivers/net/dsa/microchip/ksz_common.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 840b17b8507e1..dc96931e62da8 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -1378,6 +1378,7 @@ const struct ksz_chip_data ksz_switch_chips[] = {
.port_nirqs = 2,
.num_tx_queues = 4,
.num_ipvs = 8,
+ .tc_ets_supported = true,
.ops = &ksz9477_dev_ops,
.mib_names = ksz9477_mib_names,
.mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
@@ -1411,6 +1412,7 @@ const struct ksz_chip_data ksz_switch_chips[] = {
.port_nirqs = 2,
.num_tx_queues = 4,
.num_ipvs = 8,
+ .tc_ets_supported = true,
.ops = &ksz9477_dev_ops,
.mib_names = ksz9477_mib_names,
.mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
@@ -1442,6 +1444,7 @@ const struct ksz_chip_data ksz_switch_chips[] = {
.port_nirqs = 2,
.num_tx_queues = 4,
.num_ipvs = 8,
+ .tc_ets_supported = true,
.ops = &ksz9477_dev_ops,
.mib_names = ksz9477_mib_names,
.mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
--
2.39.2

2024-04-08 03:53:51

by Arun Ramadoss

Subject: Re: [PATCH net-next v3 7/9] net: dsa: microchip: enable ETS support for KSZ989X variants

Hi Oleksij,

On Fri, 2024-04-05 at 11:52 +0200, Oleksij Rempel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> I tested ETS support on KSZ9893, so it should work other KSZ989X
> variants too.
>
> Signed-off-by: Oleksij Rempel <[email protected]>

nitpick: For the source code I infer ets support is support for all
switches except ksz8x family(KSZ8795/4, KSZ8765 and KSZ8830).
Instead of .tc_ets_supported, can we add in the ksz_tc_setup_qdisc_ets(
)
like

if( ksz8_family())
return -EOPNOTSUPP;

Otherwise
Acked-by: Arun Ramadoss <[email protected]>

> ---
> drivers/net/dsa/microchip/ksz_common.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/dsa/microchip/ksz_common.c
> b/drivers/net/dsa/microchip/ksz_common.c
> index 840b17b8507e1..dc96931e62da8 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -1378,6 +1378,7 @@ const struct ksz_chip_data ksz_switch_chips[] =
> {
> .port_nirqs = 2,
> .num_tx_queues = 4,
> .num_ipvs = 8,
> + .tc_ets_supported = true,
> .ops = &ksz9477_dev_ops,
> .mib_names = ksz9477_mib_names,
> .mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
> @@ -1411,6 +1412,7 @@ const struct ksz_chip_data ksz_switch_chips[] =
> {
> .port_nirqs = 2,
> .num_tx_queues = 4,
> .num_ipvs = 8,
> + .tc_ets_supported = true,
> .ops = &ksz9477_dev_ops,
> .mib_names = ksz9477_mib_names,
> .mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
> @@ -1442,6 +1444,7 @@ const struct ksz_chip_data ksz_switch_chips[] =
> {
> .port_nirqs = 2,
> .num_tx_queues = 4,
> .num_ipvs = 8,
> + .tc_ets_supported = true,
> .ops = &ksz9477_dev_ops,
> .mib_names = ksz9477_mib_names,
> .mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
> --
> 2.39.2
>