2023-11-29 13:21:57

by Konrad Dybcio

Subject: Re: [PATCH 1/2] pinctrl: qcom: Convert to platform remove callback returning void

On 29.11.2023 11:04, Tengfei Fan wrote:
> Use .remove_new() instead of .remove() for converting to plarform remove
s/plarform/platform

> callback returning void.
>
> Signed-off-by: Tengfei Fan <[email protected]>
> ---
The commit title should include the platform name, i.e.
pinctrl: qcom: sm4450: xxx

The change itself looks good

Konrad

2023-11-30 01:12:22

by Tengfei Fan

Subject: Re: [PATCH 1/2] pinctrl: qcom: Convert to platform remove callback returning void

在 11/29/2023 9:21 PM, Konrad Dybcio 写道:
> On 29.11.2023 11:04, Tengfei Fan wrote:
>> Use .remove_new() instead of .remove() for converting to plarform remove
> s/plarform/platform
>
>> callback returning void.
>>
>> Signed-off-by: Tengfei Fan <[email protected]>
>> ---
> The commit title should include the platform name, i.e.
> pinctrl: qcom: sm4450: xxx
>
> The change itself looks good
>
> Konrad
Thanks Konrad review this patch, I will update patch as your comments.

--
Thx and BRs,
Tengfei Fan