2022-09-08 13:04:50

by wangjianli

[permalink] [raw]
Subject: [PATCH] drivers/scsi: fix repeated words in comments

Delete the redundant word 'in'.

Signed-off-by: wangjianli <[email protected]>
---
drivers/scsi/dc395x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 670a836a6ba1..aea82007dd61 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -4226,7 +4226,7 @@ static void adapter_init_params(struct AdapterCtlBlk *acb)
* values that we have already stored in the adapter instance. There's
* some mention that a lot of these are deprecated, so we won't use
* them (we'll use the ones in the adapter instance) but we'll fill
- * them in in case something else needs them.
+ * them in case something else needs them.
*
* The eeprom structure, irq and io ports in the adapter need to have
* been set before calling this function.
--
2.36.1


2022-09-08 13:25:14

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] drivers/scsi: fix repeated words in comments

On 08/09/2022 13:24, wangjianli wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Delete the redundant word 'in'.
>
> Signed-off-by: wangjianli <[email protected]>
> ---
> drivers/scsi/dc395x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> index 670a836a6ba1..aea82007dd61 100644
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -4226,7 +4226,7 @@ static void adapter_init_params(struct AdapterCtlBlk *acb)
> * values that we have already stored in the adapter instance. There's
> * some mention that a lot of these are deprecated, so we won't use
> * them (we'll use the ones in the adapter instance) but we'll fill
> - * them in in case something else needs them.
> + * them in case something else needs them.

Hey wangjianli,
Thanks for your patch.

This is not a typo, is it? With your "fix", it does not make sense
anymore. If you are running a tool, you should probably validate
the outputs before sending patches.
Thanks,
Conor.

> *
> * The eeprom structure, irq and io ports in the adapter need to have
> * been set before calling this function.
> --
> 2.36.1
>