2023-09-13 17:02:45

by Parthiban Veerasooran

[permalink] [raw]
Subject: Re: [RFC PATCH net-next 2/6] net: ethernet: add mac-phy interrupt support with reset complete handling

Hi Andrew,

Thank you for reviewing the patch.

On 09/09/23 7:09 pm, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> + /* Register MAC-PHY interrupt service routine */
>> + ret = devm_request_irq(&spi->dev, spi->irq, macphy_irq, 0, "macphy int",
>> + tc6);
>
> It looks like using threaded interrupts could save a lot of
> complexity. Let the IRQ core handle all the tasklet stuff for you.
Ok. If I understand correctly, I have to use devm_request_threaded_irq()
instead of devm_request_irq() and let the thread handler registered with
the devm_request_threaded_irq() function to perform interrupt activity
directly?

Best Regards,
Parthiban V
>
> Andrew