2020-05-08 14:12:43

by Yue Haibing

Subject: [PATCH -next] s390/cio: Remove unused inline functionidset_sch_get_first

commit 8ebd51a705c5 ("s390/cio: idset.c: remove some unused functions")
left behind this, remove it

Signed-off-by: YueHaibing <[email protected]>
---
drivers/s390/cio/idset.c | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/drivers/s390/cio/idset.c b/drivers/s390/cio/idset.c
index 77d0ea7b381b..45f9c0736be4 100644
--- a/drivers/s390/cio/idset.c
+++ b/drivers/s390/cio/idset.c
@@ -59,18 +59,6 @@ static inline int idset_contains(struct idset *set, int ssid, int id)
return test_bit(ssid * set->num_id + id, set->bitmap);
}

-static inline int idset_get_first(struct idset *set, int *ssid, int *id)
-{
- int bitnum;
-
- bitnum = find_first_bit(set->bitmap, set->num_ssid * set->num_id);
- if (bitnum >= set->num_ssid * set->num_id)
- return 0;
- *ssid = bitnum / set->num_id;
- *id = bitnum % set->num_id;
- return 1;
-}
-
struct idset *idset_sch_new(void)
{
return idset_new(max_ssid + 1, __MAX_SUBCHANNEL + 1);
--
2.17.1

2020-05-11 09:07:53

by Vineeth Vijayan

Subject: Re: [PATCH -next] s390/cio: Remove unused inline functionidset_sch_get_first

Thank you.
This patch will be part of the s390's next patch submission.

Reviewed-by: Vineeth Vijayan <[email protected]>

Regards,
Vineeth


On Fri, 2020-05-08 at 22:06 +0800, YueHaibing wrote:
> commit 8ebd51a705c5 ("s390/cio: idset.c: remove some unused
> functions")
> left behind this, remove it
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/s390/cio/idset.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/s390/cio/idset.c b/drivers/s390/cio/idset.c
> index 77d0ea7b381b..45f9c0736be4 100644
> --- a/drivers/s390/cio/idset.c
> +++ b/drivers/s390/cio/idset.c
> @@ -59,18 +59,6 @@ static inline int idset_contains(struct idset *set,
> int ssid, int id)
> return test_bit(ssid * set->num_id + id, set->bitmap);
> }
>
> -static inline int idset_get_first(struct idset *set, int *ssid, int
> *id)
> -{
> - int bitnum;
> -
> - bitnum = find_first_bit(set->bitmap, set->num_ssid * set-
> >num_id);
> - if (bitnum >= set->num_ssid * set->num_id)
> - return 0;
> - *ssid = bitnum / set->num_id;
> - *id = bitnum % set->num_id;
> - return 1;
> -}
> -
> struct idset *idset_sch_new(void)
> {
> return idset_new(max_ssid + 1, __MAX_SUBCHANNEL + 1);