2022-03-18 09:23:07

by Colin Ian King

Subject: [PATCH] nvmet: remove redundant assignment after left shift

The left shift is followed by a re-assignment back to cc_css,
the assignment is redundant. Fix this by replacing the <<=
operator with << instead.

Cleans up clang scan build warning:
drivers/nvme/target/core.c:1124:10: warning: Although the value
stored to 'cc_css' is used in the enclosing expression, the
value is never actually read from 'cc_css' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/nvme/target/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index 724a6d373340..75876f70a7eb 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -1121,7 +1121,7 @@ static inline u8 nvmet_cc_iocqes(u32 cc)

static inline bool nvmet_css_supported(u8 cc_css)
{
- switch (cc_css <<= NVME_CC_CSS_SHIFT) {
+ switch (cc_css << NVME_CC_CSS_SHIFT) {
case NVME_CC_CSS_NVM:
case NVME_CC_CSS_CSI:
return true;
--
2.35.1

2022-03-19 07:32:10

by Keith Busch

Subject: Re: [PATCH] nvmet: remove redundant assignment after left shift

On Fri, Mar 18, 2022 at 01:30:14AM +0000, Colin Ian King wrote:
> The left shift is followed by a re-assignment back to cc_css,
> the assignment is redundant. Fix this by replacing the <<=
> operator with << instead.
>
> Cleans up clang scan build warning:
> drivers/nvme/target/core.c:1124:10: warning: Although the value
> stored to 'cc_css' is used in the enclosing expression, the
> value is never actually read from 'cc_css' [deadcode.DeadStores]

Looks good.

Reviewed-by: Keith Busch <[email protected]>

2022-03-21 21:54:51

by Chaitanya Kulkarni

Subject: Re: [PATCH] nvmet: remove redundant assignment after left shift

On 3/17/22 18:30, Colin Ian King wrote:
> The left shift is followed by a re-assignment back to cc_css,
> the assignment is redundant. Fix this by replacing the <<=
> operator with << instead.
>
> Cleans up clang scan build warning:
> drivers/nvme/target/core.c:1124:10: warning: Although the value
> stored to 'cc_css' is used in the enclosing expression, the
> value is never actually read from 'cc_css' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>
>

Thanks, looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

-ck

2022-03-21 22:18:24

by Sagi Grimberg

Subject: Re: [PATCH] nvmet: remove redundant assignment after left shift

Reviewed-by: Sagi Grimberg <[email protected]>

2022-03-23 18:50:25

by Christoph Hellwig

Subject: Re: [PATCH] nvmet: remove redundant assignment after left shift

Thanks,

applied to nvme-5.18.