2022-11-23 03:20:09

by Dmitry Osipenko

Subject: [PATCH v9 02/11] drm/panfrost: Don't sync rpm suspension after mmu flushing

Lockdep warns about potential circular locking dependency of devfreq
with the fs_reclaim caused by immediate device suspension when mapping is
released by shrinker. Fix it by doing the suspension asynchronously.

Signed-off-by: Dmitry Osipenko <[email protected]>
---
drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c
index e246d914e7f6..99a0975f6f03 100644
--- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
@@ -273,7 +273,7 @@ static void panfrost_mmu_flush_range(struct panfrost_device *pfdev,
if (pm_runtime_active(pfdev->dev))
mmu_hw_do_operation(pfdev, mmu, iova, size, AS_COMMAND_FLUSH_PT);

- pm_runtime_put_sync_autosuspend(pfdev->dev);
+ pm_runtime_put_autosuspend(pfdev->dev);
}

static int mmu_map_sg(struct panfrost_device *pfdev, struct panfrost_mmu *mmu,
--
2.38.1

2022-11-23 16:31:50

by Steven Price

Subject: Re: [PATCH v9 02/11] drm/panfrost: Don't sync rpm suspension after mmu flushing

On 23/11/2022 02:57, Dmitry Osipenko wrote:
> Lockdep warns about potential circular locking dependency of devfreq
> with the fs_reclaim caused by immediate device suspension when mapping is
> released by shrinker. Fix it by doing the suspension asynchronously.
>
> Signed-off-by: Dmitry Osipenko <[email protected]>

Reviewed-by: Steven Price <[email protected]>

> ---
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> index e246d914e7f6..99a0975f6f03 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> @@ -273,7 +273,7 @@ static void panfrost_mmu_flush_range(struct panfrost_device *pfdev,
> if (pm_runtime_active(pfdev->dev))
> mmu_hw_do_operation(pfdev, mmu, iova, size, AS_COMMAND_FLUSH_PT);
>
> - pm_runtime_put_sync_autosuspend(pfdev->dev);
> + pm_runtime_put_autosuspend(pfdev->dev);
> }
>
> static int mmu_map_sg(struct panfrost_device *pfdev, struct panfrost_mmu *mmu,