2023-09-27 04:05:17

by chenguohua

[permalink] [raw]
Subject: [PATCH] netdev: Clean up errors in netdevice.h

Fix the following errors reported by checkpatch:

ERROR: that open brace { should be on the previous line
ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: GuoHua Cheng <[email protected]>
---
include/linux/netdevice.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 7e520c14eb8c..551372f42be6 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2306,7 +2306,7 @@ struct net_device {

struct list_head link_watch_list;

- enum { NETREG_UNINITIALIZED=0,
+ enum { NETREG_UNINITIALIZED = 0,
NETREG_REGISTERED, /* completed register_netdevice */
NETREG_UNREGISTERING, /* called unregister_netdevice */
NETREG_UNREGISTERED, /* completed unregister todo */
@@ -2501,8 +2501,7 @@ struct netdev_queue *netdev_get_tx_queue(const struct net_device *dev,
}

static inline struct netdev_queue *skb_get_tx_queue(const struct net_device *dev,
- const struct sk_buff *skb)
-{
+ const struct sk_buff *skb) {
return netdev_get_tx_queue(dev, skb_get_queue_mapping(skb));
}

--
2.17.1


2023-10-01 18:09:09

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] netdev: Clean up errors in netdevice.h

On Wed, Sep 27, 2023 at 11:37:30AM +0800, [email protected] wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: spaces required around that '=' (ctx:VxV)
>
> Signed-off-by: GuoHua Cheng <[email protected]>

Hi GuoHua Cheng,

I'm sorry, but checkpatch cleanup patches for Networking code
are not accepted.

pw-bot: rejected